-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-4347] Upgrade angular to 17 #11031
Open
Hinton
wants to merge
13
commits into
main
Choose a base branch
from
ps/angular17
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,327
โ5,970
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
46bc7cc
Upgrade angular to 17
Hinton 73a50bb
Handle routing loop on vault page
Hinton 9635dfc
Change @typescript-eslint version
Hinton b8f9b46
Merge branch 'main' of github.com:bitwarden/clients into ps/angular17
Hinton cc8be03
Update TypeScript
justindbaur 2098f21
Merge remote-tracking branch 'origin/main' into ps/angular17
justindbaur 2bb307c
Remove `isActive` Check
justindbaur f607438
Remove Extraneous Change
justindbaur b67de9f
Merge branch 'main' into ps/angular17
justindbaur fb65e47
Work Around `test:types`
justindbaur d0b9a46
Merge remote-tracking branch 'origin/main' into ps/angular17
justindbaur a1c1d1a
Fix Story
justindbaur 7285a86
Update Story Documentation
justindbaur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
import "core-js/stable"; | ||
require("zone.js/dist/zone"); | ||
import "zone.js"; | ||
|
||
if (process.env.NODE_ENV === "production") { | ||
// Production | ||
} else { | ||
// Development and test | ||
Error["stackTraceLimit"] = Infinity; | ||
require("zone.js/dist/long-stack-trace-zone"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitwarden/team-design-system Since this is just rendering text it would be fine for us to have
@
for readability or also switch it to@
so we aren't showing off invalid HTML, any preference?