[PM-4347] Upgrade angular to 17 #11031
Open
+3,327
−5,970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11031 +/- ##
==========================================
+ Coverage 33.26% 33.27% +0.01%
==========================================
Files 2789 2789
Lines 86670 86773 +103
Branches 16506 16517 +11
==========================================
+ Hits 28828 28877 +49
- Misses 55547 55601 +54
Partials 2295 2295 ☔ View full report in Codecov by Sentry. |
# Conflicts: # apps/web/src/app/vault/individual-vault/vault.component.ts # package-lock.json # package.json
justindbaur
previously approved these changes
Oct 17, 2024
coroiu
reviewed
Oct 22, 2024
| @@ -27,27 +27,28 @@ | |||
| "storybook": "ng run components:storybook", | |||
| "build-storybook": "ng run components:build-storybook", | |||
| "build-storybook:ci": "ng run components:build-storybook --webpack-stats-json", | |||
| "postinstall": "patch-package" | |||
| "postinstall": "patch-package && rimraf ./node_modules/@types/glob && rimraf ./node_modules/@types/minimatch" | |||
There was a problem hiding this comment.
question: will this fix: #11542 ?
justindbaur
reviewed
Oct 22, 2024
| @@ -71,7 +71,7 @@ The content can be a button, anchor, or static container. | |||
| <bit-item> | |||
| <button bit-item-content type="button"> | |||
| <bit-avatar slot="start" text="Foo"></bit-avatar> | |||
| [email protected] | |||
There was a problem hiding this comment.
@bitwarden/team-design-system Since this is just rendering text it would be fine for us to have @ for readability or also switch it to @ so we aren't showing off invalid HTML, any preference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-4347
📔 Objective
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes