ci(msrv): bump MSRV to 1.75 and rustls to 0.23.21
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
force-pushed
the
ci/bump-msrv-to-1.75
branch
from
9e15fc7 to
f929568
Compare
oleonardolima
changed the title
1.75 and rustls to 0.23.21
oleonardolima
requested review from
notmandatory,
evanlinjin and
ValuedMammal
oleonardolima
force-pushed
the
ci/bump-msrv-to-1.75
branch
from
e913400 to
a55f51c
Compare
This was referenced Jan 20, 2025
- bumps the MSRV on CI to 1.75. - updates the `Cargo.toml` rust-version to 1.75. - removes the guideline to pin `rustls` version, as previously required by old 1.63 MSRV. - update `README.md` badges to `1.75` MSRV. - update `clippy.toml` to `1.75` MSRV.
- updates the rust version on clippy step to `1.84` - fixes the found clippy issues
oleonardolima
force-pushed
the
ci/bump-msrv-to-1.75
branch
from
a55f51c to
3dc4dac
Compare
|
Looks good to me, except CI still believes that Test (1.63.0) is a required check? |
Yes, that's weird. I guess it could be ignored, seems to not be blocking. |
notmandatory
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Jan 21, 2025
c8b55da chore: fix punctuation and use `rustup override set` instead (Leonardo L.) 78bbfbe ci: add `pin-msrv.sh` (valued mammal) f7c9bc5 docs: update `README.md` with MSRV policy (valued mammal) 12eabd1 chore(cleanup): remove rustls from pinned deps (Leonardo Lima) e3faeb6 ci: add secondary MSRV job of 1.75.0 (Leonardo Lima) Pull request description: partially fixes #1750 <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description <!-- Describe the purpose of this PR, what's being adding and/or fixed --> It adds a secondary MSRV version of `1.75.0` for the `bdk_electrum` crate, excluding it from the `1.63.0` MSRV dependency pinning and CI step. As it's the new CI will run without `bdk_electrum` for `1.63.0` MSRV step, will run another step for `1.75.0` MSRV and the latest stable. Currently,, the only affected crate is `electrum-client`, therefore `bdk-electrum`, as it relies directly on `rustls` which migrated to `1.71.0` MSRV. The `esplora-client` relies on `rustls` as a dependency of `minreq` or `reqwest`, but those crates didn't upgraded it's `rustls` versions yet. In a further PR it should also bump the `electrum-client` crate to it's latest version, which relies on `1.75.0` MSRV, see bitcoindevkit/rust-electrum-client#159. ### Notes to the reviewers <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> It's open for discussion if this approach is the expected one, or another one would be better. ### Changelog notice <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> - Add a secondary MSRV of `1.75.0` for `bdk_electrum`. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR ACKs for top commit: notmandatory: ACK c8b55da Tree-SHA512: 186d82d6d295c688a608e1dd457e2718e0ae3ee92b7d1a0aad094711c3baeb70dccd581e3067e6305c1fc702c78f1704399f7472a5ae62824041ac68c384b770
notmandatory
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
ACK 3dc4dac
before we merge this I'd like to get a 👍 from top production dependents:
- ldk_node (current MSRV 1.63) @tnull
- lightning-transaction-sync (no MSRV?) @TheBlueMatt
- bdk_reserves (current MSRV 1.63) @ulrichard
|
I update the CI required MSRV test version to |
Can confirm the new MSRV for LDK Node and |
|
Ok with me. |
Yes, on our end we tried very hard to stay on 1.63, too. Unfortunately we depend on |
|
Thanks all for the feedback. I'll work with @oleonardolima to figure out if anything else needs to be done before publishing a new release of this crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes bitcoindevkit/bdk#1750
It bumps the project MSRV to
1.75.0in order to follow along with LDK changes, and to remove the pinned version ofrustls, which now is under1.71MSRV, bumping it to latest0.23.21.It also updates the
clippystep on CI to use rust1.84, fixing the found clippy issues.