-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add secondary MSRV job of 1.75.0 #1803
ci: add secondary MSRV job of 1.75.0 #1803
Conversation
fd10d46
to
42c2a4b
Compare
I sort of like the idea of separating the "check" and "test" jobs. For example this CI run https://github.com/ValuedMammal/bdk/actions/runs/12872751304 |
That's a good idea, I'll cherry-pick the commit. |
However, @ValuedMammal any reason to not have tests run with |
I thought the same thing and I don't know. It didn't seem like that would pick up any tests that weren't already included in |
I cherry-picked and add the features to matrix, but it now fails because not all crates has |
735c116
to
ac3dcd7
Compare
Alright, I kept it all under a single build-test job, using the It should be ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I found a couple nits to fix and it needs to be rebased now that #1801 is merged.
- bdk_electrum: add MSRV section to README.md
- add ci/pin-msrv.sh, which pins the dependencies for 1.63.0 MSRV
- fix some nits and punctuation typos. - recommend usage of `rustup override set` instead of `rustup default` command. Co-authored-by: Steve Myers <[email protected]>
d411cec
to
c8b55da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c8b55da
I updated Github required checks to match changes in this PR. |
partially fixes #1750
Description
It adds a secondary MSRV version of
1.75.0
for thebdk_electrum
crate, excluding it from the1.63.0
MSRV dependency pinning and CI step.As it's the new CI will run without
bdk_electrum
for1.63.0
MSRV step, will run another step for1.75.0
MSRV and the latest stable.Currently,, the only affected crate is
electrum-client
, thereforebdk-electrum
, as it relies directly onrustls
which migrated to1.71.0
MSRV. Theesplora-client
relies onrustls
as a dependency ofminreq
orreqwest
, but those crates didn't upgraded it'srustls
versions yet.In a further PR it should also bump the
electrum-client
crate to it's latest version, which relies on1.75.0
MSRV, see bitcoindevkit/rust-electrum-client#159.Notes to the reviewers
It's open for discussion if this approach is the expected one, or another one would be better.
Changelog notice
1.75.0
forbdk_electrum
.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: