Migrate package to Typescript and new build system #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(addresses #6) |
tokebe
changed the title
|
Additional changes:
|
|
Note: tests pass on local -- PR is ready to go. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates package to typescript with minimal implementation changes. Several types were duplicated to support this, in the future BTE should be broken up into more packages (such as an
@biothings_explorer/types) to allow for better import control and increased maintainability.See biothings/bte_trapi_query_graph_handler/pull/170 for requirements to merge and further details on the migration.
As with the above, tests work locally -- something must be wrong in the GitHub Actions config.