Migrate package to Typescript and new build system #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that these PRs are not ready -- there seem to still be some compile errors when using them in a fresh clone. Will update when fixed. |
tokebe
changed the title
|
Additional changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the entirety of this package to Typescript with minimal implementation changes. Typescript will make it harder to break things when developing new features, as well as facilitate future refactoring.
Note that all tests pass on a local instance. Something must be going wrong with the present github actions testing system.
Requires the following PRs:
biothings/biothings_explorer#740
biothings/call-apis.js/pull/72
biothings/api-respone-transform.js#57
biothings/smartapi-kg.js#84
biothings/biomedical_id_resolver.js#108
biothings/biolink-model.js#34
biothings/node-expansion#3