-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAMA 1445 - Add client side Optimizely code #12177
Open
holchris
wants to merge
34
commits into
latest
Choose a base branch
from
WSTEAMA-1445-add-client-side-optimizely-code
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−9
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
c829f39
adds optimizely to event tracking unit test
holchris bdd9c8b
adds optimizely to jump to component
holchris 3268ec1
rename flagId to jump_to
holchris abfd9fa
adds optimizely to event tracking
holchris 30cac22
adds optimizely to jump to on article page
holchris 5ff8503
adds jest mock for optimizely article page unit test
holchris 8ab380a
adds withOptimizelyProvider to article page
holchris 67211d2
import order
louisearchibald ca84058
Merge branch 'latest' into WSTEAMA-1445-add-client-side-optimizely-code
louisearchibald bebb715
Merge branch 'WSTEAMA-1445-add-client-side-optimizely-code' of github…
louisearchibald 6ef9764
import order
louisearchibald 19e20b8
test to see if ci check will pass
louisearchibald 38ca07f
Merge branch 'latest' into WSTEAMA-1445-add-client-side-optimizely-code
louisearchibald bb8030c
Merge branch 'WSTEAMA-1445-add-client-side-optimizely-code' of github…
louisearchibald 70665d8
Revert "test to see if ci check will pass"
louisearchibald ec73032
temp remove code from jumpTo render on Article page
louisearchibald fa9e6bf
Revert "temp remove code from jumpTo render on Article page"
louisearchibald 1742947
Merge branch 'latest' into WSTEAMA-1445-add-client-side-optimizely-code
louisearchibald 17f2e34
typo
louisearchibald 4a9d986
move optimizelyScrollDepth out of Article page
louisearchibald 21c28c7
remove optimizelyScrollDepth
louisearchibald 8a7dfe4
Merge branch 'WSTEAMA-1445-add-client-side-optimizely-code' of github…
louisearchibald 49b1d05
remove import
louisearchibald ce6c94b
Merge branch 'latest' into WSTEAMA-1445-add-client-side-optimizely-code
louisearchibald 47e1d7e
Merge branch 'WSTEAMA-1445-add-client-side-optimizely-code' of github…
louisearchibald 7b48a97
revert to scrollable_promo for now
louisearchibald 1dd08e8
test update
louisearchibald d80b290
changed the wrong thing
louisearchibald d21dd63
move scroll depth back to article page to fix test failure
louisearchibald ac58a91
remove scroll depth from jump to index
louisearchibald 343b753
name changes
louisearchibald 167afb4
move scrollDepth back to jumpTo component
louisearchibald dc90eae
move optimizely scroll depth mock to jumpTo test file
louisearchibald 2a37d84
small change
louisearchibald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import withOptimizelyProvider from '#app/legacy/containers/PageHandlers/withOptimizelyProvider'; | ||
import ArticlePage from './ArticlePage'; | ||
import applyBasicPageHandlers from '../utils/applyBasicPageHandlers'; | ||
|
||
export default applyBasicPageHandlers(ArticlePage); | ||
const OptimizelyArticle = withOptimizelyProvider(ArticlePage); | ||
|
||
export default applyBasicPageHandlers(OptimizelyArticle); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Thinking about it, maybe we should just go the whole way now and return
null
if its noton
.We can force ourselves into the experiment and toggle the variations to test that it shows/hides correctly. So probably best to do that now too.