WSTEAMA 1445 - Add client side Optimizely code #12177
Open
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:bbc/simorgh into WSTEAMA-1445-add-client-side-optimizely-code
….com:bbc/simorgh into WSTEAMA-1445-add-client-side-optimizely-code
This reverts commit 19e20b8.
This reverts commit ec73032.
….com:bbc/simorgh into WSTEAMA-1445-add-client-side-optimizely-code
….com:bbc/simorgh into WSTEAMA-1445-add-client-side-optimizely-code
amoore108
reviewed
Nov 15, 2024
amoore108
reviewed
Nov 15, 2024
| ) : ( | ||
| <JumpTo {...props} /> | ||
| ), | ||
| jumpToVariation === 'on' ? <JumpTo {...props} /> : <JumpTo {...props} />, |
There was a problem hiding this comment.
Looks good 👍
Thinking about it, maybe we should just go the whole way now and return null if its not on.
We can force ourselves into the experiment and toggle the variations to test that it shows/hides correctly. So probably best to do that now too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA 1445
Overall changes
Adds and updates any Optimizely code required to run our experiment of the JumpTo component on Article pages.
Code changes
scrollable_promoreferences tojump_to