Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated label crate to understand canonical vs apparent repositories #2507

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

UebelAndre
Copy link
Collaborator

Doing my best to adhere to https://bazel.build/concepts/labels. This change updates the label utility to account for modern changes to Bazel labels (e.g. from bzlmod).

@UebelAndre
Copy link
Collaborator Author

@hlopko if you have time, would love to know if this still works for your use cases. I did my best to keep the spirit of the original Label impl you added in #724

util/label/label.rs Outdated Show resolved Hide resolved
util/label/label.rs Outdated Show resolved Hide resolved
@UebelAndre UebelAndre added this pull request to the merge queue Feb 22, 2024
Merged via the queue into bazelbuild:main with commit 998f7d5 Feb 22, 2024
3 checks passed
@UebelAndre UebelAndre deleted the label branch February 22, 2024 15:27
qtica added a commit to qtica/rules_rust that referenced this pull request Apr 1, 2024
…azelbuild#2507)

Doing my best to adhere to https://bazel.build/concepts/labels. This
change updates the label utility to account for modern changes to Bazel
labels (e.g. from bzlmod).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants