Network.ts - script hangs when reassigning w/ ContractFactory::deploy #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local bridging script hangs indefinitely while waiting for the `InterchainTokenFactoryContract` deployment. This is likely due to the fact that the `ethersJS::Contract::deployed()` method is invoked twice for the same variable, `implementation`. EthersJS seems to get confused when using `let implementation = await deployContract(<InterchainTokenServiceContract>)` and then reassigning like so: `implementation = await deployContract(<InterchainTokenFactoryContract>)` since `deployContract()` calls `await contract.deployed()` Using a single const variable for each contract returned by `deployContract()` resolved the issue, as made in this PR
|
I don't think the variable reassigning causes the script to hang because we didn't pass that variable into the |
npty
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local bridging script hangs indefinitely while waiting for the
InterchainTokenFactoryContractdeployment.This is likely due to the fact that the
ethersJS::Contract::deployed()method is invoked twice for the same variable,implementation. EthersJS seems to get confused when usinglet implementation = await deployContract(<InterchainTokenServiceContract>)and then reassigning like so:implementation = await deployContract(<InterchainTokenFactoryContract>)sincedeployContract()callsawait contract.deployed()Using a single const variable for each contract returned by
deployContract()resolved the issue, as made in this PR