Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network.ts - script hangs when reassigning w/ ContractFactory::deploy #113

Merged
merged 1 commit into from
Aug 7, 2024

Commits on Aug 6, 2024

  1. Network.ts - script hangs when reassigning w/ ContractFactory::deploy

    Local bridging script hangs indefinitely while waiting for the `InterchainTokenFactoryContract` deployment. 
    
    This is likely due to the fact that the `ethersJS::Contract::deployed()` method is invoked twice for the same variable, `implementation`.  EthersJS seems to get confused when using 
    `let implementation = await deployContract(<InterchainTokenServiceContract>)`
    and then reassigning like so:
    `implementation = await deployContract(<InterchainTokenFactoryContract>)`
    since `deployContract()` calls `await contract.deployed()`
    
    Using a single const variable for each contract returned by `deployContract()` resolved the issue, as made in this PR
    robriks authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    92c7760 View commit details
    Browse the repository at this point in the history