Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#1778 feat: added PooledThreadExecutor::WaitUntilStopped function + updates #2787

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Dec 12, 2023

Issue #, if available:
Updating the PR for #1778
Description of changes:

  1. Add proposed method to the base interface class
  2. Implement in a default executor
  3. Split Executor uber-files into specific headers and translation units
    Check all that applies:
  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl
Copy link
Contributor

note that cspell is failing for

203/393 ./src/aws-cpp-sdk-core/include/aws/core/utils/threading/PooledThreadExecutor.h 6.29ms X
/Users/sbiscigl/aws-sdk-cpp/src/aws-cpp-sdk-core/include/aws/core/utils/threading/PooledThreadExecutor.h:50:38 - Unknown word (threadpool)

if you could add that to the cspell word check in this PR

@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review December 13, 2023 17:32
@SergeyRyabinin SergeyRyabinin merged commit eb8afc5 into main Dec 13, 2023
4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/1778 branch December 13, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants