Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added PooledThreadExecutor::WaitUntilStopped function #1778

Closed
wants to merge 1 commit into from

Conversation

fboranek
Copy link

Issue #, if available: #1776

Description of changes:
to able to wait to safe release shared_ptr for executor in a main thread

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.) - I didn't find any specific test for PooledThreadExecutor but it used in many other test, so it should be covered.
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Current

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmklix jmklix added the needs-review This issue or pull request needs review from a core team member. label Jun 16, 2022
jmklix added a commit that referenced this pull request Jan 18, 2023
@jmklix jmklix requested review from jmklix and removed request for jmklix January 18, 2023 19:34
@SergeyRyabinin
Copy link
Contributor

Hello,

I have integrated your patch as a part of this PR: #2787

Thank you a lot for your contribution.
Please sorry it took so long to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants