Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong variable in comparison code for verification #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wrong variable in comparison code for verification #28

wants to merge 1 commit into from

Commits on Nov 2, 2024

  1. wrong variable in comparison code for verification 

    the code will always print "NKI and NumPy match" even when they might actually differ. The comparison needs to be between the NKI output (out_nki) and the NumPy output (out_np) to properly verify if they produce the same results.

Not sure if this shows up in a doc or test anywhere else.
    @jimburtoft
    jimburtoft authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    bc81495 View commit details
    Browse the repository at this point in the history