Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong variable in comparison code for verification #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimburtoft
Copy link

the code will always print "NKI and NumPy match" even when they might actually differ. The comparison needs to be between the NKI output (out_nki) and the NumPy output (out_np) to properly verify if they produce the same results.

Not sure if this shows up in a doc or test anywhere else.

Testing:

Please see detailed unit test requirements in the CONTRIBUTING.md

  • The change FIXES the numeric checking
  • The change is covered by numeric check using nki.baremetal
  • The change is covered by performance benchmark test using nki.benchmark
  • The change is covered by end-to-end integration test

Pull Request Checklist

  • [ x] I have filled in all the required field in the template
  • I have tested locally that all the tests pass. (I just eyeballed this, but I'm pretty confident)
  • [x ] By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

the code will always print "NKI and NumPy match" even when they might actually differ. The comparison needs to be between the NKI output (out_nki) and the NumPy output (out_np) to properly verify if they produce the same results.

Not sure if this shows up in a doc or test anywhere else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant