Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make FramesFromNow() accept a float arg #416

Merged
merged 1 commit into from
Jul 3, 2024
Merged

make FramesFromNow() accept a float arg #416

merged 1 commit into from
Jul 3, 2024

Commits on Jul 3, 2024

  1. make FramesFromNow() accept a float arg

    Well, this is embarrassing.
    
    Most of the time FrameFromNow() is passed an integer.  But there's an important call that passes a float on this check:
        while (FramesFromNow(latencyTolerance) > topSentFrame) {
            itsNet->FrameAction();
        }
    
    Passing latencyTolerance as an integer was truncating the LT.  For example, an LT=1.5 would be treated as LT=1 and result in
    less than the full LT of frames being sent on time.
    tra committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2b07dfc View commit details
    Browse the repository at this point in the history