make FramesFromNow() accept a float arg #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, this is embarrassing.
Most of the time FrameFromNow() is passed an integer. But there's an important call that passes a float on this check:
while (FramesFromNow(latencyTolerance) > topSentFrame) {
itsNet->FrameAction();
}
Passing latencyTolerance as an integer was truncating the LT. For example, an LT=1.5 would be treated as LT=1 and result in
less than the full LT of frames being sent on time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this is embarrassing.
Most of the time FrameFromNow() is passed an integer. But there's an important call that passes a float on this check:
while (FramesFromNow(latencyTolerance) > topSentFrame) {
itsNet->FrameAction();
}
Passing latencyTolerance as an integer was truncating the LT. For example, an LT=1.5 would be treated as LT=1 and result in less than the full LT of frames being sent on time.