refactor(test_utils): return parser as optional #9391
+31
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zulfaqar Azmi <[email protected]>
zulfaqar-azmi-t4
requested review from
mkquda,
rej55,
kosuke55,
maxime-clem,
satoshi-ota,
shmpwk,
TomohitoAndo,
tkimura4,
go-sakayori,
soblin,
takayuki5168,
kyoichi-sugahara and
TakaHoribe
as code owners
github-actions
bot
added
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
reviewed
Nov 20, 2024
| @@ -581,7 +581,7 @@ TEST(ParseFunction, CompleteFromFilename) | |||
| const auto parser_test_route = | |||
| autoware_test_utils_dir + "/test_data/lanelet_route_parser_test.yaml"; | |||
|
|
|||
| const auto lanelet_route = parse<LaneletRoute>(parser_test_route); | |||
| const auto lanelet_route = *parse<std::optional<LaneletRoute>>(parser_test_route); | |||
There was a problem hiding this comment.
Suggested change
| const auto lanelet_route = *parse<std::optional<LaneletRoute>>(parser_test_route); | |
| if (const auto lanelet_route_opt = parse<std::optional<LaneletRoute>>(parser_test_route); lanelet_route_opt) { | |
| const auto lanelet_route = lanelet_route_opt.value(); | |
| // do the tests ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible the the parser function is being used incorrectly, which will return in correct results.
This PR refactor the function to return optional instead.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.