Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pid_longitudinal_controller): suppress rclcpp_warning/error #9384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 19, 2024

Description

Suppress the too-frequent MPC's warning which fills the terminal.
Instead, set a diag with a detailed reason, and show it on the terminal once as follows.
image

Related links

How was this PR tested?

unit test passed perfectly, and psim worked as expected.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 marked this pull request as ready for review November 19, 2024 08:47
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 29.65%. Comparing base (b4603fd) to head (8291abd).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...nal_controller/src/pid_longitudinal_controller.cpp 37.93% 14 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9384      +/-   ##
==========================================
- Coverage   29.66%   29.65%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      103204   103228      +24     
  Branches    40216    40239      +23     
==========================================
+ Hits        30611    30617       +6     
- Misses      69638    69654      +16     
- Partials     2955     2957       +2     
Flag Coverage Δ *Carryforward flag
differential 32.45% <40.00%> (?)
total 29.65% <ø> (-0.01%) ⬇️ Carriedforward from b4603fd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants