Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_rviz_plugin): add parameter of max_line_text_num #9370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

feat(tier4_system_rviz_plugin): add parameter of max_line_text_num

1380f79
Select commit
Loading
Failed to load commit list.
Open

feat(tier4_system_rviz_plugin): add parameter of max_line_text_num #9370

feat(tier4_system_rviz_plugin): add parameter of max_line_text_num
1380f79
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 19, 2024 in 1m 18s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.45 -> 9.44)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method mrm_summary_overlay_display.cpp: MrmSummaryOverlayDisplay::update

Annotations

Check warning on line 184 in common/tier4_system_rviz_plugin/src/mrm_summary_overlay_display.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

MrmSummaryOverlayDisplay::update already has high cyclomatic complexity, and now it increases in Lines of Code from 72 to 73. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.