Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): do not insert shift end pose on pull over lane to path #9361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 18, 2024

Description

If the same pose is inserted for points with different lateral positions, it will not be smooth when interpolating with splines. It would be smoother if the same posture is not inserted.

before:

image

after #9361:

image

Related links

Parent Issue:

  • Link

How was this PR tested?

psim

2024/11/18 https://evaluation.tier4.jp/evaluation/reports/e8cf2a22-b4a4-5fb4-ab12-f7f654ba4f12/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@kosuke55 kosuke55 marked this pull request as ready for review November 18, 2024 09:52
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.64%. Comparing base (cdb6e88) to head (488e2d3).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9361      +/-   ##
==========================================
- Coverage   29.66%   29.64%   -0.02%     
==========================================
  Files        1338     1341       +3     
  Lines      103204   103261      +57     
  Branches    40216    40218       +2     
==========================================
  Hits        30615    30615              
- Misses      69633    69690      +57     
  Partials     2956     2956              
Flag Coverage Δ *Carryforward flag
differential 0.52% <ø> (?)
total 29.66% <ø> (+<0.01%) ⬆️ Carriedforward from cdb6e88

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants