Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pool statistics #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add pool statistics #3

wants to merge 6 commits into from

Commits on Jun 16, 2017

  1. Support for statistics endpoints 

    Add support for different endpoint types - extend the Resourcer interface
for this, since the private methods already prevent out-of-package resourcer
implementations.

Specifically add the statistics path stub, and add helpers and types to get
pool statistics.
    @dombenson
    dombenson committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    c9dbcb6 View commit details
    Browse the repository at this point in the history

  2. Add stats resources to readme 

    Add entries for the 22 statistics resource types to the readme
Clarify sections for config and stats
Mark pools as implemented
    @dombenson
    dombenson committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    3da679b View commit details
    Browse the repository at this point in the history

  3. Return err rather than panic 

    Whilst falling through the type switch probably indicates a package-internal error,
return an error rather than panicing as callers already have to handle this.
    @dombenson
    dombenson committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    e561100 View commit details
    Browse the repository at this point in the history

  4. Remove debug println

    @dombenson
    dombenson committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    7753f74 View commit details
    Browse the repository at this point in the history

  5. Remove debug println

    @dombenson
    dombenson committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    f706dba View commit details
    Browse the repository at this point in the history

  6. Hi/lo are unsigned 

    The traffic counters are split into high and low bits for 32-bit values
These are actually uint32, not int32
    @dombenson
    dombenson committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    5193794 View commit details
    Browse the repository at this point in the history