Add pool statistics #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for different endpoint types - extend the Resourcer interface for this, since the private methods already prevent out-of-package resourcer implementations. Specifically add the statistics path stub, and add helpers and types to get pool statistics.
Add entries for the 22 statistics resource types to the readme Clarify sections for config and stats Mark pools as implemented
Whilst falling through the type switch probably indicates a package-internal error, return an error rather than panicing as callers already have to handle this.
The traffic counters are split into high and low bits for 32-bit values These are actually uint32, not int32
|
This looks good. Sorry I havnt been looking at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.