Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: DAO Wallet Connect Main Flow #908

Merged
merged 5 commits into from
Jul 10, 2023
Merged

Feat: DAO Wallet Connect Main Flow #908

merged 5 commits into from
Jul 10, 2023

Conversation

RakeshUP
Copy link
Contributor

@RakeshUP RakeshUP commented Jul 5, 2023 •
edited by jira bot
Loading

Description

Pending flows:

  • To check mobile UI
  • Action builder accordion for WC actions and Execution Widget APP-2264
  • cleanup useWalletConnectInterceptor hook

Task: APP-2263, APP-2265, APP-2266

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@RakeshUP RakeshUP requested a review from a team July 5, 2023 06:46
@Fabricevladimir Fabricevladimir self-requested a review July 5, 2023 10:11
Fabricevladimir
Fabricevladimir requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, Rakesh! Lots of good stuff here! Left a few minor comments

packages/web-app/src/containers/walletConnect/dAppValidationModal/index.tsx Outdated Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/dAppValidationModal/index.tsx Show resolved Hide resolved
packages/web-app/src/containers/actionBuilder/index.tsx Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/index.tsx Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/dAppValidationModal/index.tsx Outdated Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/connectedAppsModal/index.tsx Outdated Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/connectedAppsModal/index.tsx Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/actionListenerModal/index.tsx Outdated Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/actionListenerModal/index.tsx Outdated Show resolved Hide resolved
packages/web-app/src/containers/walletConnect/connectedAppsModal/index.tsx Show resolved Hide resolved
@Fabricevladimir Fabricevladimir mentioned this pull request Jul 7, 2023
Merged
12 tasks
Fabricevladimir
Fabricevladimir reviewed Jul 9, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once that external link comes in, I think this will be good to merge! Thanks

packages/web-app/src/containers/walletConnect/dAppValidationModal/index.tsx Show resolved Hide resolved
packages/web-app/src/hooks/useWalletConnectInterceptor.ts Show resolved Hide resolved
Fabricevladimir
Fabricevladimir approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@RakeshUP RakeshUP merged commit 0ba64fa into develop Jul 10, 2023
5 of 6 checks passed
@RakeshUP RakeshUP deleted the f/2260 branch July 10, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir approved these changes

Assignees
No one assigned
Labels
web-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RakeshUP @Fabricevladimir