Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: APP-2264 - Action Builder & Execution Widget #911

Merged
merged 23 commits into from
Jul 10, 2023

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Jul 7, 2023

Description

  • Adds an Action Builder card for the WC action
  • Reuses card in Execution Widget for WC action
  • Allows proposal creation with WC action
  • Decodes WC action

NOTE: Can use Uniswap or AAVE app for testing

This PR's branched off of #908 and will rebased once that has been merged

TODO:

  • Merge SCC and WC decoding and Execution Widget Card
  • Missing translation strings

Task: APP-2264

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team July 7, 2023 02:12
@Fabricevladimir Fabricevladimir force-pushed the f/app-2264 branch 2 times, most recently from 168097d to 32acde1 Compare July 10, 2023 09:40
@Fabricevladimir Fabricevladimir changed the title WIP Feature: APP-2264 - Action Builder & Execution Widget Feature: APP-2264 - Action Builder & Execution Widget Jul 10, 2023
@Fabricevladimir Fabricevladimir marked this pull request as ready for review July 10, 2023 11:02
@Fabricevladimir Fabricevladimir merged commit 37e1709 into develop Jul 10, 2023
5 of 6 checks passed
@Fabricevladimir Fabricevladimir deleted the f/app-2264 branch July 10, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants