Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(hugo): Upgrade to v0.102.3 #63

Closed
wants to merge 1 commit into from
Closed

deps(hugo): Upgrade to v0.102.3 #63

wants to merge 1 commit into from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Sep 3, 2022

Hold onto merging until peaceiris/actions-hugo#605 is merged.

Signed-off-by: Simar [email protected]

@simar7
Copy link
Member Author

simar7 commented Apr 18, 2024

@DmitriyLewen since you are here, do you think we should at some point bump Hugo? I'm sure the newer versions would reduce build time thereby reducing GitHub Actions runner time.

@DmitriyLewen
Copy link
Collaborator

DmitriyLewen commented Apr 19, 2024

I used hugo v0.121.0 on my local PC to create a local site.
This still requires a lot of time and resources, but I haven't noticed any problems with the vulnerability pages.

So, I think we can try to bump hugo.

@simar7 But this PR is outdated.

@simar7
Copy link
Member Author

simar7 commented Apr 19, 2024

I used hugo v0.121.0 on my local PC to create a local site.

This still requires a lot of time and resources, but I haven't noticed any problems with the vulnerability pages.

So, I think we can try to bump hugo.

@simar7 But this PR is outdated.

I see thanks for checking.

Did your local full build take less time with the recent version of Hugo?

@DmitriyLewen
Copy link
Collaborator

Did your local full build take less time with the recent version of Hugo?

I only worked with this version, but I can try to check.

@simar7
Copy link
Member Author

simar7 commented May 14, 2024

Did your local full build take less time with the recent version of Hugo?

I only worked with this version, but I can try to check.

Did you have any update @DmitriyLewen

@DmitriyLewen
Copy link
Collaborator

Hello @simar7
Sorry, i was busy with other tasks.

I tried to check this, but my Mac killed hugo 😄 :

time hugo --destination=docs      
Start building sites … 
hugo v0.121.0-e321c3502aa8e80a7a7c951359339a985f082757+extended darwin/arm64 BuildDate=2023-12-05T15:22:31Z VendorInfo=brew

[2]    70243 killed     hugo --destination=docs
hugo --destination=docs  522.21s user 382.57s system 112% cpu 13:25.25 total

I wanted to compare time in CI/CD of my fork, but hugo-action still didn't fix peaceiris/actions-hugo#605.
Latest possible version for MacOS is 0.101.0.

Do you have any info why we use macos runner to build site?

@DmitriyLewen
Copy link
Collaborator

I compare currently version with 0.101.0. 0.101.0 is faster:
0.81.0 worked 32 min and was killed - https://github.com/DmitriyLewen/avd-generator/actions/runs/9090148356/job/24982466479#step:18:8
0.101.0 created site for 28 min - https://github.com/DmitriyLewen/avd-generator/actions/runs/9090338993/job/24982997298#step:18:1

@nikpivkin
Copy link
Collaborator

nikpivkin commented May 15, 2024

@DmitriyLewen I tried to run site generation locally, but it eats up all my machine resources :)

@simar7
Copy link
Member Author

simar7 commented May 16, 2024

Do you have any info why we use macos runner to build site?

@DmitriyLewen it actually used to be the case that the macOS runners were more powerful in compute and memory as compared to their linux counterparts. So we moved from linux to macOS.

But I just checked, it seems that the linux ones have also caught up and now actually offer more https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories. Also the latest Mac runners (macOS-14) are now M1 based instead of the older intel ones.

It would be worth to try out using both macOS-14 and the linux runners again.

@DmitriyLewen
Copy link
Collaborator

@DmitriyLewen I tried to run site generation locally, but it eats up all my machine resources :)

Same case 😞

It would be worth to try out using both macOS-14 and the linux runners again.

Let's try using Linux first.

@simar7
Copy link
Member Author

simar7 commented May 17, 2024

Superseded by e5aaf2f

@simar7 simar7 closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants