Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(GitHub): Update cron.yml #85

Merged
merged 2 commits into from
May 16, 2024
Merged

chore(GitHub): Update cron.yml #85

merged 2 commits into from
May 16, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented May 14, 2024

Looks like the runner is failing in the latest release of macOS environment in GitHub Actions. We can pin it to version 13 like so: https://github.com/lammps/lammps/pull/4146/files#diff-aa0563933da21476e08bd72b9ce1988e6d33e60fea45ab3b562ea3da5c5ac2cbR18

@nikpivkin
Copy link
Collaborator

@simar7 What actions are completed unsuccessfully? I see that the step "Deploy Search Index to MeiliSearch Instance" exceeds the timeout, is that it?

@simar7
Copy link
Member Author

simar7 commented May 15, 2024

@simar7 What actions are completed unsuccessfully? I see that the step "Deploy Search Index to MeiliSearch Instance" exceeds the timeout, is that it?

The step to upload artifacts fails as we cannot install the awscli within the GitHub actions repo.

@DmitriyLewen
Copy link
Collaborator

I've already seen this error
This error appears to be related to Python 3.11+ -
We can use venv or --break-system-packages flag.

Take a look https://stackoverflow.com/a/76641565

@nikpivkin
Copy link
Collaborator

I'm leaning toward creating a virtual environment.

@DmitriyLewen
Copy link
Collaborator

Agree with you!
--break-system-packages is an unsafe workaround.

@simar7
Copy link
Member Author

simar7 commented May 16, 2024

Agree with you!
--break-system-packages is an unsafe workaround.

That was also why I thought it was better to downgrade to a known environment rather than use the --break-system-packages flag.

In order to get the builds up and running again, should we downgrade first and then work on the virtual environment setup?

We could also go back to linux, see details in this comment.

Let me know what you both think.

@DmitriyLewen
Copy link
Collaborator

DmitriyLewen commented May 16, 2024

should we downgrade first

IIRC this error is not related to OS version. Have you tried running action in MacOS 13?
I think MacOS 13 has the same version of Python out of the box.

We could also go back to linux, see details in #63 (comment) comment.

I think we need to start by using Linux.
Hugo-action still doesn't support Hugo >= 0.102.0.
Maybe the new versions of Hugo will be faster.

@simar7
Copy link
Member Author

simar7 commented May 16, 2024

@simar7
I checked a little:
It should help for MacOS runner - https://github.com/DmitriyLewen/test-trivy-action/blob/8b3680c252bf8a964ec963c8949e026effcd9efe/.github/workflows/test-action.yaml#L12-L14
test run - https://github.com/DmitriyLewen/test-trivy-action/actions/runs/9106569045/job/25033982408

Nice, this is looking good. I'd say we go with your idea. If you want to push your changes to my branch that's fine too.

@DmitriyLewen
Copy link
Collaborator

I don't have permission for this 😞 :

ERROR: Permission to aquasecurity/avd-generator.git denied to DmitriyLewen.

@simar7
Copy link
Member Author

simar7 commented May 16, 2024

As discussed with @DmitriyLewen offline, we will merge this as is and come back to switching over to Linux in a future PR.

@simar7 simar7 merged commit f22a7ea into main May 16, 2024
2 checks passed
@DmitriyLewen DmitriyLewen deleted the fix-macos-runner branch May 16, 2024 06:09
DmitriyLewen added a commit to DmitriyLewen/avd-generator that referenced this pull request May 17, 2024
simar7 pushed a commit that referenced this pull request May 21, 2024
* Revert "chore(GitHub): Update cron.yml (#85)"

This reverts commit f22a7ea.

* fix: download vuln-list-redhat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants