Batch events #8

GabrielRozendo · 2024-02-14T12:14:18Z

Refactoring:

Unify to get both system info and OS Name once and changed to not null.
InitOptions in a separated file with more options.
Normalized ' and ".
Private fields.
Not null when possible.
Handle logs.

Add:

Storage (as abstract/interface) to persist events for offline and to accumulate before send in batch.
Check lifecycle, if the app goes to inactive or paused states, send events.
Send events in batch (customized).
If an error happens, check to try again later (internet issues or 5xx status code) or discard events (4xx status code).

In this moment, using Hive but could be implement using anything.

Changed to not null

- InitOptions in separated file with more options - Normalized ' and " - Private fields - Not null when possible - Handle logs - Add storage to persist events (offline and acumulate before send in batch) - Add lifecycle to check if the app went to inactive or paused states - Send events in batch to endpoint events - If an error happened, check to try again or discard events

GabrielRozendo · 2024-02-14T12:18:45Z

Hi @goenning
Does are PR welcome?

I've been hosting the Aptabase in a small VPS and it is handling huge requests.
I know about PR #6 and as it has a new approach and seems no more active, I'm trying a simpler approach to help (including for my VPS' health 😅).
Did everything thinking in your comments there and approaches used in another SDKs too.

Please check it out and give your feedback.
It is in WIP (work in progress) yet, need to update readme/instructions about them and review some unecessary comments.
Let me know about your thoughts.

Thank you.

goenning · 2024-02-19T08:45:29Z

Hi @GabrielRozendo thanks for the PR, just letting you know that I'll have a look at it this week :)

goenning · 2024-02-21T20:15:15Z

Hi @GabrielRozendo seems pretty good to me!

Will it work with flutter on web?
Have you tried using it on your app?
It's currently in Draft, are you looking to add more things before publishing?

GabrielRozendo · 2024-02-22T12:10:02Z

Hi @goenning
1: Yes, as Hive and SharedPrefs work for web, it'll be too!
2: Yes, I'm trying in beta right now (2 users) and so far so good. Not released to public yet.
3: I want to check and test more, decide between Hive and SharedPrefs (1), plus, release to my public app and follow how it would be going (2)

It was only a preview to get your firstly impressions and check if it is going good for you.
Good to know!

goenning · 2024-03-17T07:18:11Z

@GabrielRozendo just a heads up that there might be some minor conflicts due to package updates on pubspec.yaml

GabrielRozendo · 2024-04-02T07:41:08Z

@goenning no problem so far and I've found a case.
My server was rebooting (intentionally) and as I was debugging the Flutter app, I validated another scenario.

Logs

[Aptabase] Checking events, reason: init
[Aptabase] Sent 30 events successfully
[Aptabase] Aptabase initilized!
[Aptabase] TrackEvent failed with status code 502. Response:

<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.22.1</center>
</body>
</html>

[Aptabase] Checking events, reason: timer
[Aptabase] Sent 30 events successfully
[Aptabase] TrackEvent failed with status code 502. Response:

<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.22.1</center>
</body>
</html>

[Aptabase] Checking events, reason: timer
[Aptabase] TrackEvent Exception: SocketException: Connection refused (OS Error: Connection refused, errno = 61), address = aptabase.myserver.com, port = 51030
[Aptabase] SocketException (SocketException: Connection refused (OS Error: Connection refused, errno = 61), address = aptabase.myserver.com, port = 51030)
[Aptabase]

           #0      _NativeSocket.startConnect (dart:io-patch/socket_patch.dart:721:35)
           #1      _RawSocket.startConnect (dart:io-patch/socket_patch.dart:1914:26)
           #2      RawSocket.startConnect (dart:io-patch/socket_patch.dart:27:23)
           #3      RawSecureSocket.startConnect (dart:io/secure_socket.dart:299:22)
           #4      SecureSocket.startConnect (dart:io/secure_socket.dart:77:28)
           #5      _ConnectionTarget.connect (dart:_http/http_impl.dart:2483:26)
           #6      _HttpClient._getConnection.connect (dart:_http/http_impl.dart:2926:12)
           #7      _HttpClient._getConnection (dart:_http/http_impl.dart:2931:12)
           #8      _HttpClient._openUrl (dart:_http/http_impl.dart:2786:12)
           #9      _HttpClient.postUrl (dart:_http/http_impl.dart:2633:49)
           #10     Aptabase._send (package:aptabase_flutter/aptabase_flutter.dart:223:35)
           #11     Aptabase._tick (package:aptabase_flutter/aptabase_flutter.dart:144:28)
           <asynchronous suspension>

[Aptabase] Checking events, reason: timer
[Aptabase] Sent 30 events successfully
[Aptabase] TrackEvent failed with status code 502. Response:

<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.22.1</center>
</body>
</html>

[Aptabase] Checking events, reason: timer
[Aptabase] Sent 30 events successfully
[Aptabase] TrackEvent failed with status code 400. Response: Too many events (30) in a single request. Maximum is 25.
[Aptabase] Checking events, reason: timer
[Aptabase] Sent 22 events successfully
[Aptabase] Checking events, reason: timer

I'll change this sentence to remove the word successfully. At this point we don't know yet.
Sent 30 events successfully

But my real question here is about that 400 response.
The server has a max limit for 25? If so, we should handle this case. I can change that as well.

[Aptabase] TrackEvent failed with status code 400. Response: Too many events (30) in a single request. Maximum is 25.

goenning · 2024-04-02T17:40:40Z

Yes, there’s a limit of 25 events per request, so the SDK has to create chunks of up to 25 events before sending the request.

GabrielRozendo · 2024-06-14T11:43:47Z

Hey @goenning
Just updated the PR with main

Not in progress anymore.
No problem so far and feel free to review/approve it

cristipufu

Thanks @GabrielRozendo!

Let's also update the version of the sdk and add a new entry in the CHANGELOG

cristipufu · 2024-07-10T06:43:59Z

pubspec.yaml

We need to update the version of the sdk to 0.4.0:
version: 0.4.0

cristipufu · 2024-07-10T06:44:23Z

lib/aptabase_flutter.dart

-  static const Duration _sessionTimeout = Duration(hours: 1);
+  Aptabase._();
+
+  static const _sdkVersion = "[email protected]";


static const _sdkVersion = "[email protected]";

flutter-painter · 2024-10-23T13:01:15Z

Hi, @GabrielRozendo ,

Thank you again, I gave it a look, but fail to grasp it.
Would it please be possible to include a short example on how to handle aptabase with persistence ?
My main concern is that it seems the storage solution (e.g. Hive) needs to be instantiated in the aptabase.init in the main.dart
In my case this is not possible as storage solution is instantiated much further down the widget tree

GabrielRozendo · 2024-10-29T19:29:39Z

Hi @flutter-painter

indeed, the aptabase.init initialize one storage if you don't provide it, the default one is Hive.

I'm not sure about your specific case but even if you init our storage solution later, as the aptabase init it anyway, I'm not sure if it is a real problem. Maybe you'd have two diff storage solution (one for Aptabase and other for you app).

Also, you could init the aptabase after init your storage solution, not exactly on main.dart (in my apps I use this approach).
You can use even other diff than Hive.

In example/main.dart in PR #13 I've included one using SharedPreferences.

GabrielRozendo added 2 commits February 14, 2024 11:47

Refactoring to unify to get both system info and OS Name once.

3c7d539

Changed to not null

GabrielRozendo marked this pull request as draft February 14, 2024 12:18

GabrielRozendo changed the title ~~[WIP] Batch events~~ Draft: Batch events Feb 14, 2024

GabrielRozendo added 2 commits February 14, 2024 12:33

Lint changes

71e28aa

export to avoid users create a new import

92d5720

Add shared_preferences option as Local Storage

671ec1a

GabrielRozendo added 4 commits March 20, 2024 14:36

Merge branch 'main' into batch_events

acd6897

Remove sharedprefs

6978265

bump version

ab4760a

dependency as any

ff70653

Assert max events limit to 25

31be3fc

GabrielRozendo marked this pull request as ready for review April 3, 2024 00:19

GabrielRozendo changed the title ~~Draft: Batch events~~ Batch events Apr 3, 2024

cristipufu mentioned this pull request Jun 11, 2024

feat: update packages to make it compatible with flutter 3.22.X #12

Merged

cristipufu force-pushed the main branch from fda37c9 to 96b273e Compare June 11, 2024 08:35

GabrielRozendo added 2 commits June 14, 2024 12:32

Merge branch 'main' into batch_events

1f7bccf

example

52ce1af

cristipufu reviewed Jul 10, 2024

View reviewed changes

cristipufu merged commit 54e827e into aptabase:main Aug 27, 2024

cristipufu mentioned this pull request Aug 27, 2024

offline #2

Closed

GabrielRozendo mentioned this pull request Sep 3, 2024

Propose for 0.4.1 improvements #13

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch events #8

Batch events #8

GabrielRozendo commented Feb 14, 2024

GabrielRozendo commented Feb 14, 2024

goenning commented Feb 19, 2024

goenning commented Feb 21, 2024

GabrielRozendo commented Feb 22, 2024

goenning commented Mar 17, 2024

GabrielRozendo commented Apr 2, 2024

goenning commented Apr 2, 2024

GabrielRozendo commented Jun 14, 2024

cristipufu left a comment

cristipufu Jul 10, 2024

cristipufu Jul 10, 2024

flutter-painter commented Oct 23, 2024

GabrielRozendo commented Oct 29, 2024

Batch events #8

Batch events #8

Conversation

GabrielRozendo commented Feb 14, 2024

GabrielRozendo commented Feb 14, 2024

goenning commented Feb 19, 2024

goenning commented Feb 21, 2024

GabrielRozendo commented Feb 22, 2024

goenning commented Mar 17, 2024

GabrielRozendo commented Apr 2, 2024

goenning commented Apr 2, 2024

GabrielRozendo commented Jun 14, 2024

cristipufu left a comment

Choose a reason for hiding this comment

cristipufu Jul 10, 2024

Choose a reason for hiding this comment

cristipufu Jul 10, 2024

Choose a reason for hiding this comment

flutter-painter commented Oct 23, 2024

GabrielRozendo commented Oct 29, 2024