Propose for 0.4.1 improvements

[GabrielRozendo]

Quoting changelog.md

0.4.1

• Handle the lifecycle using AppLifecycleListener instead SystemChannels.lifecycle.setMessageHandler
• Changed trackEvent to not future
  Avoiding calling unawaited every time you want to track a new event.
  The lint rule: https://dart.dev/tools/linter-rules/unawaited_futures
• Fix the error message when appKey is invalid
• Update example with latest flutter version and an "app opened" event
• Fix web info

1. Lifecycle issue

The PR #8 is working as should

but now I need to listen the flutter's lifecycle in my app (not in aptabase's package) and since the package already is doing that and as documented on SystemChannels.lifecycle:

/// The given callback will replace the currently registered callback for this
/// channel, if any. To remove the handler, pass null as the handler
/// argument.

we would lose the feature "send events when app goes to background".
And I've found out the SystemChannels.lifecycle has other unwanted side effects in general.

2. Changed trackEvent to not future

I use the unawaited_futures lint rule so I should add the unawaited every time I want to track and already create a caller just to wrap it. Thinking in other users and in this lint, changed it to not future anymore.

The problem here is if the dev already implemented either await or unawaited when calling the trackEvents, it'd be an error (as it is not future anymore) and will break (so shouldn't be only minor bump 0.4.1). I prefer to avoid that.

One solution would be implement another caller as not future and (maybe) add a deprecated in future caller.
I really want to hear you about that before.

3. Fix web info

In web is flagging OS as unknown.
In package DeviceInfoPlugin has the implementation for web platform, check out in pub.dev example

Already change to use the webBrowserInfo

The issue here is the version part as the web provides not a clear single option to use.

In documentation has these info:

 Map<String, dynamic> _readWebBrowserInfo(WebBrowserInfo data) {
    return <String, dynamic>{
      'browserName': data.browserName.name,
      'appCodeName': data.appCodeName,
      'appName': data.appName,
      'appVersion': data.appVersion,
      'deviceMemory': data.deviceMemory,
      'language': data.language,
      'languages': data.languages,
      'platform': data.platform,
      'product': data.product,
      'productSub': data.productSub,
      'userAgent': data.userAgent,
      'vendor': data.vendor,
      'vendorSub': data.vendorSub,
      'hardwareConcurrency': data.hardwareConcurrency,
      'maxTouchPoints': data.maxTouchPoints,
    };
  }

Here is my debug value:

We could use the appVersion but still not so clear and simple.
And yet we should limit it to 100 max chars as server defined.
39: osInfo.version.substring(0, 100),

Again I want to know what your opinion before move on.

---

Sorry for long message but want to discuss before open the PR itself and also if you want to, I can break the PRs in 1,2,3 parts if you'd prefer.

[GabrielRozendo]

Already tested on iOS, Mac, Web and Android.

[manuthebyte]

Handle the lifecycle using AppLifecycleListener instead SystemChannels.lifecycle.setMessageHandler

Great and veeerrrryyy important change. The big issue about the approach before is that you set the message handler to your method for the whole app. The rest of the app will not be able to receive app lifecycle events.

[GabrielRozendo]

The big issue about the approach before is that you set the message handler to your method for the whole app. The rest of the app will not be able to receive app lifecycle events.

Indeed. I realized one day after merged 😔
You could said it before 😅🥲

What else can you comment?

[manuthebyte]

Indeed. I realized one day after merged 😔

Thats unfortunate 😞

You could said it before 😅🥲

I just realized it when we had this bug in one of our apps. I was thinking "Why can't I receive lifecycle events" until we bruteforce-removed every plugin until we knew it was aptabase 😆
Just saw it in the code.

What else can you comment?

What do you mean? Feedback for the rest of the code? 😄