Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Grid Widget #2389

Merged
merged 556 commits into from
Apr 23, 2021
Merged

[Feature] Grid Widget #2389

merged 556 commits into from
Apr 23, 2021

Conversation

jsartisan
Copy link
Contributor

Description

Introducing new widget for lists/grid

Fixes #1427

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jsartisan jsartisan marked this pull request as draft December 29, 2020 10:54
@ofpiyush ofpiyush added the Enhancement New feature or request label Dec 29, 2020
@riodeuno riodeuno added the Widgets Product This label groups issues related to widgets label Jan 4, 2021
@riodeuno riodeuno self-requested a review January 4, 2021 06:55
riodeuno and others added 26 commits January 15, 2021 16:02
@riodeuno
Merge branch 'fix/property-pane-bindings' of github.com:appsmithorg/a…
ec0f075 
…ppsmith into tests/property-pane-bindings
Merge branch 'fix/property-pane-bindings' of https://github.com/appsm…
08fb0b9 
…ithorg/appsmith into tests/property-pane-bindings
Updated test
fd487ff
Merge branch 'tests/property-pane-bindings' of https://github.com/app…
129254e 
…smithorg/appsmith into tests/property-pane-bindings
updated assertions
e48a2f4
@vicky-primathon
Resizing image to take full width of table cell
223ef84
updated assertion
f0f918e
@riodeuno
Stop updating dynamicBindingPathList directly from widget
a0b5046
@riodeuno
Merge branch 'tests/property-pane-bindings' of github.com:appsmithorg…
1ff7a38 
…/appsmith into tests/property-pane-bindings
@riodeuno
Fix selectedRow and selectedRows computations
715c246
@riodeuno
Merge branch 'release' of github.com:appsmithorg/appsmith into tests/…
a066478 
…property-pane-bindings
@riodeuno
Fix primaryColumns computations
1b14bbd
Updated test for derived column
117fd11
Added tests for computed value
e089144
Added check clear data
7ef52e3
Reordering of test
582ecd5
updated common method
2e7d692
@vicky-primathon
Made image size as 100% of table cell size
3019c08
add templating logic
f16f542
Updated flow and dsl
f58a65a
Merge branch 'tests/property-pane-bindings' of https://github.com/app…
340ef79 
…smithorg/appsmith into tests/property-pane-bindings
@riodeuno
Clear old primary columns
17cca39
@riodeuno
Merge branch 'tests/property-pane-bindings' of github.com:appsmithorg…
e9f11e1 
…/appsmith into tests/property-pane-bindings
Updated testname
fde66e2
@riodeuno
Merge branch 'release' of github.com:appsmithorg/appsmith into tests/…
3eb022a 
…property-pane-bindings
@riodeuno
Merge branch 'release' of github.com:appsmithorg/appsmith into tests/…
88ce4ac 
…property-pane-bindings
@github-actions
Copy link

Test coverage results 🧪

Code coverage diff between base branch:release and head branch: feature/list-grid-widget
Status File % Stmts % Branch % Funcs % Lines
🟢 total 47.73 (2.43) 29.82 (2.59) 26.15 (4.85) 47.9 (2.36)
✨ 🆕 app/client/src/actions/apiPaneActions.ts 68 100 0 52.94
🟢 app/client/src/actions/propertyPaneActions.ts 85.71 (10.71) 100 (0) 50 (50) 80 (13.33)
🟢 app/client/src/components/ads/Icon.tsx 57.69 (1.1) 36.99 (1.37) 100 (0) 57.46 (1.11)
🟢 app/client/src/components/ads/ScrollIndicator.tsx 82.22 (64.44) 53.13 (40.63) 86.67 (86.67) 78.38 (56.76)
🟢 app/client/src/components/ads/Tooltip.tsx 100 (14.29) 100 (100) 100 (100) 100 (14.29)
🟢 app/client/src/components/designSystems/appsmith/PositionedContainer.tsx 100 (33.33) 80 (60) 100 (100) 100 (35.71)
🟢 app/client/src/components/editorComponents/DragLayerComponent.tsx 71.43 (48.35) 30 (25.24) 84.62 (84.62) 69.23 (44.23)
🟢 app/client/src/components/editorComponents/DraggableComponent.tsx 72.88 (51.45) 41.03 (30.5) 53.33 (53.33) 71.7 (48.17)
🟢 app/client/src/components/editorComponents/DropTargetComponent.tsx 18 (1.67) 2.53 (-0.14) 0 (0) 19.1 (0.92)
🟢 app/client/src/components/editorComponents/ErrorBoundry.tsx 76.19 (19.05) 87.5 (37.5) 42.86 (28.57) 73.68 (15.79)
🟢 app/client/src/components/editorComponents/ResizableComponent.tsx 55.56 (34.57) 15.25 (15.25) 55.56 (55.56) 54.43 (32.91)
🟢 app/client/src/components/editorComponents/ResizeStyledComponents.tsx 100 (5.26) 96.43 (3.57) 100 (100) 100 (5.26)
🟢 app/client/src/components/editorComponents/CodeEditor/BindingPrompt.tsx 85 (55) 64.29 (35.72) 100 (100) 85 (55)
🟢 app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx 71.67 (36.67) 60.87 (29.05) 52.38 (52.38) 70.18 (35.09)
🟢 app/client/src/components/editorComponents/CodeEditor/index.tsx 47.87 (23.81) 23.42 (23.42) 26.67 (23.34) 48.59 (23.59)
🟢 app/client/src/components/editorComponents/CodeEditor/styledComponents.ts 92.42 (77.27) 56.7 (48.45) 100 (100) 95.31 (79.68)
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/LightningMenuTrigger.tsx 88.24 54.55 90 86.21
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/helpers.tsx 58.82 25 20 53.33
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/hooks.ts 76.92 25 50 73.91
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/index.tsx 91.3 0 66.67 90
🟢 app/client/src/components/editorComponents/WidgetNameComponent/SettingsControl.tsx 92.59 (25.92) 76.92 (15.38) 100 (83.33) 92.31 (26.93)
🟢 app/client/src/components/editorComponents/WidgetNameComponent/index.tsx 77.78 (51.11) 60 (46.67) 88.89 (88.89) 78.57 (52.38)
🟢 app/client/src/constants/IconConstants.tsx 100 (0) 92.86 (14.29) 100 (0) 100 (0)
🟢 app/client/src/constants/messages.ts 69.32 (1.58) 100 (0) 7.78 (4.77) 72.08 (0.23)
🟢 app/client/src/icons/ControlIcons.tsx 53.01 (1.2) 100 (0) 2.5 (2.5) 53.01 (1.2)
🟢 app/client/src/icons/WidgetIcons.tsx 54.17 (2) 100 (0) 4.35 (4.35) 54.17 (2)
🟢 app/client/src/mockResponses/WidgetConfigResponse.tsx 28 (-7.29) 9.38 (9.38) 28.57 (28.57) 27.78 (-7.51)
🟢 app/client/src/pages/Editor/Popper.tsx 65.12 (30.24) 28.26 (19.56) 44.44 (44.44) 64.29 (30.96)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/StyledComponents.tsx 32 46.15 5.56 32
🟢 app/client/src/pages/common/CustomizedDropdown/dropdownHelpers.tsx 39.29 (7.15) 6.67 (6.67) 33.33 (33.33) 37.04 (7.41)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/index.tsx 79.41 42.86 83.33 77.42
🟢 app/client/src/resizable/index.tsx 45.76 (30.51) 35 (25) 31.58 (31.58) 45.83 (27.08)
🟢 app/client/src/sagas/WidgetBlueprintSagas.ts 30.36 (5.36) 3.13 (-5.57) 11.11 (-3.18) 34 (4.37)
✨ 🆕 app/client/src/sagas/WidgetBlueprintSagasEnums.ts 100 100 100 100
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 7.61 (-0.19) 1 (-0.07) 3.23 (0.06) 8.72 (-0.21)
✨ 🆕 app/client/src/sagas/WidgetOperationUtils.ts 69.39 44.44 50 67.39
🟢 app/client/src/selectors/applicationSelectors.tsx 75.34 (1.37) 59.09 (0) 63.64 (4.55) 70.18 (0)
🟢 app/client/src/selectors/dataTreeSelectors.ts 66.67 (14.82) 30 (30) 33.33 (33.33) 60.87 (13.04)
🟢 app/client/src/selectors/editorSelectors.tsx 45.38 (4.61) 5.71 (5.71) 7.14 (4.76) 41.12 (5.61)
🟢 app/client/src/selectors/entitiesSelector.ts 37.26 (1.88) 1.39 (1.39) 3.95 (3.95) 33.33 (1.88)
🟢 app/client/src/selectors/propertyPaneSelectors.tsx 51.85 (15.85) 20 (20) 66.67 (66.67) 52 (14.5)
🟢 app/client/src/selectors/themeSelectors.tsx 88.24 (11.77) 75 (25) 60 (20) 91.67 (16.67)
🟢 app/client/src/utils/AppsmithUtils.tsx 46.59 (2.27) 13.41 (2.43) 33.33 (5.55) 40.52 (2.61)
🟢 app/client/src/utils/WidgetPropsUtils.tsx 18.34 (0.69) 0.81 (0.81) 2.5 (2.5) 15.19 (0.75)
🟢 app/client/src/utils/generators.tsx 76.19 (4.76) 33.33 (0) 50 (25) 76.92 (7.69)
🟢 app/client/src/utils/helpers.tsx 39.37 (0.66) 5.26 (0) 4.35 (-0.2) 30 (0.41)
🟢 app/client/src/utils/autocomplete/EntityDefinitions.ts 46.67 (3.81) 0 (0) 25 (25) 46.67 (3.81)
🟢 app/client/src/utils/hooks/dragResizeHooks.tsx 45.83 (12.5) 0 (0) 18.75 (18.75) 40 (15)
🟢 app/client/src/utils/hooks/useClickOpenPropPane.tsx 80 (48) 0 (0) 80 (80) 82.61 (52.18)
🟢 app/client/src/widgets/BaseWidget.tsx 74.04 (29.92) 33.33 (33.33) 51.85 (48.15) 72.73 (26.81)
✨ 🆕 app/client/src/widgets/MetaHOC.tsx 20 0 15.38 21.57
✨ 🆕 app/client/src/widgets/ListWidget/ListComponent.tsx 70 66.67 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPagination.tsx 70 33.33 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPropertyPaneConfig.ts 60 100 0 60
✨ 🆕 app/client/src/widgets/ListWidget/ListWidget.tsx 37.19 21.18 17.14 36.22
🟢 app/client/src/workers/validations.ts 44.1 (2.77) 36.53 (2.31) 47.73 (3.83) 43.93 (2.53)

@github-actions
Copy link

Current PR reduces the test coverage percentage by 2 for some tests

@github-actions
Copy link

Test coverage results 🧪

Code coverage diff between base branch:release and head branch: feature/list-grid-widget
Status File % Stmts % Branch % Funcs % Lines
🟢 total 47.73 (2.43) 29.82 (2.59) 26.15 (4.85) 47.9 (2.36)
✨ 🆕 app/client/src/actions/apiPaneActions.ts 68 100 0 52.94
🟢 app/client/src/actions/propertyPaneActions.ts 85.71 (10.71) 100 (0) 50 (50) 80 (13.33)
🟢 app/client/src/components/ads/Icon.tsx 57.69 (1.1) 36.99 (1.37) 100 (0) 57.46 (1.11)
🟢 app/client/src/components/ads/ScrollIndicator.tsx 82.22 (64.44) 53.13 (40.63) 86.67 (86.67) 78.38 (56.76)
🟢 app/client/src/components/ads/Tooltip.tsx 100 (14.29) 100 (100) 100 (100) 100 (14.29)
🟢 app/client/src/components/designSystems/appsmith/PositionedContainer.tsx 100 (33.33) 80 (60) 100 (100) 100 (35.71)
🟢 app/client/src/components/editorComponents/DragLayerComponent.tsx 71.43 (48.35) 30 (25.24) 84.62 (84.62) 69.23 (44.23)
🟢 app/client/src/components/editorComponents/DraggableComponent.tsx 72.88 (51.45) 41.03 (30.5) 53.33 (53.33) 71.7 (48.17)
🟢 app/client/src/components/editorComponents/DropTargetComponent.tsx 18 (1.67) 2.53 (-0.14) 0 (0) 19.1 (0.92)
🟢 app/client/src/components/editorComponents/ErrorBoundry.tsx 76.19 (19.05) 87.5 (37.5) 42.86 (28.57) 73.68 (15.79)
🟢 app/client/src/components/editorComponents/ResizableComponent.tsx 55.56 (34.57) 15.25 (15.25) 55.56 (55.56) 54.43 (32.91)
🟢 app/client/src/components/editorComponents/ResizeStyledComponents.tsx 100 (5.26) 96.43 (3.57) 100 (100) 100 (5.26)
🟢 app/client/src/components/editorComponents/CodeEditor/BindingPrompt.tsx 85 (55) 64.29 (35.72) 100 (100) 85 (55)
🟢 app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx 71.67 (36.67) 60.87 (29.05) 52.38 (52.38) 70.18 (35.09)
🟢 app/client/src/components/editorComponents/CodeEditor/index.tsx 47.87 (23.81) 23.42 (23.42) 26.67 (23.34) 48.59 (23.59)
🟢 app/client/src/components/editorComponents/CodeEditor/styledComponents.ts 92.42 (77.27) 56.7 (48.45) 100 (100) 95.31 (79.68)
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/LightningMenuTrigger.tsx 88.24 54.55 90 86.21
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/helpers.tsx 58.82 25 20 53.33
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/hooks.ts 76.92 25 50 73.91
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/index.tsx 91.3 0 66.67 90
🟢 app/client/src/components/editorComponents/WidgetNameComponent/SettingsControl.tsx 92.59 (25.92) 76.92 (15.38) 100 (83.33) 92.31 (26.93)
🟢 app/client/src/components/editorComponents/WidgetNameComponent/index.tsx 77.78 (51.11) 60 (46.67) 88.89 (88.89) 78.57 (52.38)
🟢 app/client/src/constants/IconConstants.tsx 100 (0) 92.86 (14.29) 100 (0) 100 (0)
🟢 app/client/src/constants/messages.ts 69.32 (1.58) 100 (0) 7.78 (4.77) 72.08 (0.23)
🟢 app/client/src/icons/ControlIcons.tsx 53.01 (1.2) 100 (0) 2.5 (2.5) 53.01 (1.2)
🟢 app/client/src/icons/WidgetIcons.tsx 54.17 (2) 100 (0) 4.35 (4.35) 54.17 (2)
🟢 app/client/src/mockResponses/WidgetConfigResponse.tsx 28 (-7.29) 9.38 (9.38) 28.57 (28.57) 27.78 (-7.51)
🟢 app/client/src/pages/Editor/Popper.tsx 65.12 (30.24) 28.26 (19.56) 44.44 (44.44) 64.29 (30.96)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/StyledComponents.tsx 32 46.15 5.56 32
🟢 app/client/src/pages/common/CustomizedDropdown/dropdownHelpers.tsx 39.29 (7.15) 6.67 (6.67) 33.33 (33.33) 37.04 (7.41)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/index.tsx 79.41 42.86 83.33 77.42
🟢 app/client/src/resizable/index.tsx 45.76 (30.51) 35 (25) 31.58 (31.58) 45.83 (27.08)
🟢 app/client/src/sagas/WidgetBlueprintSagas.ts 30.36 (5.36) 3.13 (-5.57) 11.11 (-3.18) 34 (4.37)
✨ 🆕 app/client/src/sagas/WidgetBlueprintSagasEnums.ts 100 100 100 100
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 7.61 (-0.19) 1 (-0.07) 3.23 (0.06) 8.72 (-0.21)
✨ 🆕 app/client/src/sagas/WidgetOperationUtils.ts 69.39 44.44 50 67.39
🟢 app/client/src/selectors/applicationSelectors.tsx 75.34 (1.37) 59.09 (0) 63.64 (4.55) 70.18 (0)
🟢 app/client/src/selectors/dataTreeSelectors.ts 66.67 (14.82) 30 (30) 33.33 (33.33) 60.87 (13.04)
🟢 app/client/src/selectors/editorSelectors.tsx 45.38 (4.61) 5.71 (5.71) 7.14 (4.76) 41.12 (5.61)
🟢 app/client/src/selectors/entitiesSelector.ts 37.26 (1.88) 1.39 (1.39) 3.95 (3.95) 33.33 (1.88)
🟢 app/client/src/selectors/propertyPaneSelectors.tsx 51.85 (15.85) 20 (20) 66.67 (66.67) 52 (14.5)
🟢 app/client/src/selectors/themeSelectors.tsx 88.24 (11.77) 75 (25) 60 (20) 91.67 (16.67)
🟢 app/client/src/utils/AppsmithUtils.tsx 46.59 (2.27) 13.41 (2.43) 33.33 (5.55) 40.52 (2.61)
🟢 app/client/src/utils/WidgetPropsUtils.tsx 18.34 (0.69) 0.81 (0.81) 2.5 (2.5) 15.19 (0.75)
🟢 app/client/src/utils/generators.tsx 76.19 (4.76) 33.33 (0) 50 (25) 76.92 (7.69)
🟢 app/client/src/utils/helpers.tsx 39.37 (0.66) 5.26 (0) 4.35 (-0.2) 30 (0.41)
🟢 app/client/src/utils/autocomplete/EntityDefinitions.ts 46.67 (3.81) 0 (0) 25 (25) 46.67 (3.81)
🟢 app/client/src/utils/hooks/dragResizeHooks.tsx 45.83 (12.5) 0 (0) 18.75 (18.75) 40 (15)
🟢 app/client/src/utils/hooks/useClickOpenPropPane.tsx 80 (48) 0 (0) 80 (80) 82.61 (52.18)
🟢 app/client/src/widgets/BaseWidget.tsx 74.04 (29.92) 33.33 (33.33) 51.85 (48.15) 72.73 (26.81)
✨ 🆕 app/client/src/widgets/MetaHOC.tsx 20 0 15.38 21.57
✨ 🆕 app/client/src/widgets/ListWidget/ListComponent.tsx 70 66.67 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPagination.tsx 70 33.33 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPropertyPaneConfig.ts 60 100 0 60
✨ 🆕 app/client/src/widgets/ListWidget/ListWidget.tsx 37.19 21.18 17.14 36.22
🟢 app/client/src/workers/validations.ts 44.1 (2.77) 36.53 (2.31) 47.73 (3.83) 43.93 (2.53)

@github-actions
Copy link

Current PR reduces the test coverage percentage by 2 for some tests

riodeuno
riodeuno approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@riodeuno riodeuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for CI tests to run.

riodeuno
riodeuno requested changes Apr 20, 2021
View reviewed changes
app/client/src/components/designSystems/appsmith/PositionedContainer.tsx Outdated Show resolved Hide resolved
app/client/src/components/propertyControls/DropDownControl.tsx Show resolved Hide resolved
app/client/src/constants/HelpConstants.ts Outdated Show resolved Hide resolved
app/client/src/constants/ReduxActionConstants.tsx Outdated Show resolved Hide resolved
app/client/src/constants/messages.test.ts Outdated Show resolved Hide resolved
app/client/src/widgets/ContainerWidget.tsx Outdated Show resolved Hide resolved
app/client/src/widgets/ListWidget/ListComponent.tsx Outdated Show resolved Hide resolved
app/client/src/widgets/ListWidget/ListWidget.tsx Show resolved Hide resolved
app/client/src/widgets/ListWidget/ListWidget.tsx Outdated Show resolved Hide resolved
app/client/src/widgets/ListWidget/ListWidget.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

Test coverage results 🧪

Code coverage diff between base branch:release and head branch: feature/list-grid-widget
Status File % Stmts % Branch % Funcs % Lines
🟢 total 47.86 (2.48) 29.98 (2.63) 26.29 (4.91) 48 (2.39)
✨ 🆕 app/client/src/actions/apiPaneActions.ts 68 100 0 52.94
🟢 app/client/src/actions/propertyPaneActions.ts 85.71 (10.71) 100 (0) 50 (50) 80 (13.33)
🟢 app/client/src/components/ads/Icon.tsx 57.69 (1.1) 36.99 (1.37) 100 (0) 57.46 (1.11)
🟢 app/client/src/components/ads/ScrollIndicator.tsx 82.22 (64.44) 53.13 (40.63) 86.67 (86.67) 78.38 (56.76)
🟢 app/client/src/components/ads/Tooltip.tsx 100 (14.29) 100 (100) 100 (100) 100 (14.29)
🟢 app/client/src/components/designSystems/appsmith/PositionedContainer.tsx 100 (33.33) 80 (60) 100 (100) 100 (35.71)
🟢 app/client/src/components/editorComponents/DragLayerComponent.tsx 71.43 (48.35) 30 (25.24) 84.62 (84.62) 69.23 (44.23)
🟢 app/client/src/components/editorComponents/DraggableComponent.tsx 72.88 (51.45) 41.03 (30.5) 53.33 (53.33) 71.7 (48.17)
🟢 app/client/src/components/editorComponents/DropTargetComponent.tsx 18 (1.67) 2.53 (-0.14) 0 (0) 19.1 (0.92)
🟢 app/client/src/components/editorComponents/ErrorBoundry.tsx 76.19 (19.05) 87.5 (37.5) 42.86 (28.57) 73.68 (15.79)
🟢 app/client/src/components/editorComponents/ResizableComponent.tsx 55.56 (34.57) 15.25 (15.25) 55.56 (55.56) 54.43 (32.91)
🟢 app/client/src/components/editorComponents/ResizeStyledComponents.tsx 100 (5.26) 96.43 (3.57) 100 (100) 100 (5.26)
🟢 app/client/src/components/editorComponents/CodeEditor/BindingPrompt.tsx 85 (55) 64.29 (35.72) 100 (100) 85 (55)
🟢 app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx 71.67 (36.67) 60.87 (29.05) 52.38 (52.38) 70.18 (35.09)
🟢 app/client/src/components/editorComponents/CodeEditor/index.tsx 47.87 (23.81) 23.42 (23.42) 26.67 (23.34) 48.59 (23.59)
🟢 app/client/src/components/editorComponents/CodeEditor/styledComponents.ts 92.42 (77.27) 56.7 (48.45) 100 (100) 95.31 (79.68)
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/LightningMenuTrigger.tsx 88.24 54.55 90 86.21
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/helpers.tsx 58.82 25 20 53.33
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/hooks.ts 76.92 25 50 73.91
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/index.tsx 91.3 0 66.67 90
🟢 app/client/src/components/editorComponents/WidgetNameComponent/SettingsControl.tsx 92.59 (25.92) 76.92 (15.38) 100 (83.33) 92.31 (26.93)
🟢 app/client/src/components/editorComponents/WidgetNameComponent/index.tsx 77.78 (51.11) 60 (46.67) 88.89 (88.89) 78.57 (52.38)
🟢 app/client/src/constants/DefaultTheme.tsx 88.78 (10.21) 88.89 (8.33) 60.71 (3.57) 86.59 (6.1)
🟢 app/client/src/constants/IconConstants.tsx 100 (0) 92.86 (14.29) 100 (0) 100 (0)
🟢 app/client/src/constants/messages.ts 69.32 (1.58) 100 (0) 7.78 (4.77) 72.08 (0.23)
🟢 app/client/src/icons/ControlIcons.tsx 53.01 (1.2) 100 (0) 2.5 (2.5) 53.01 (1.2)
🟢 app/client/src/icons/WidgetIcons.tsx 54.17 (2) 100 (0) 4.35 (4.35) 54.17 (2)
🟢 app/client/src/mockResponses/WidgetConfigResponse.tsx 28 (-7.29) 9.38 (9.38) 28.57 (28.57) 27.78 (-7.51)
🟢 app/client/src/pages/Editor/Popper.tsx 65.12 (30.24) 28.26 (19.56) 44.44 (44.44) 64.29 (30.96)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/StyledComponents.tsx 32 46.15 5.56 32
🟢 app/client/src/pages/common/CustomizedDropdown/dropdownHelpers.tsx 39.29 (7.15) 6.67 (6.67) 33.33 (33.33) 37.04 (7.41)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/index.tsx 79.41 42.86 83.33 77.42
🟢 app/client/src/resizable/index.tsx 45.76 (30.51) 35 (25) 31.58 (31.58) 45.83 (27.08)
🟢 app/client/src/sagas/WidgetBlueprintSagas.ts 30.36 (5.36) 3.13 (-5.57) 11.11 (-3.18) 34 (4.37)
✨ 🆕 app/client/src/sagas/WidgetBlueprintSagasEnums.ts 100 100 100 100
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 7.61 (-0.19) 1 (-0.07) 3.23 (0.06) 8.72 (-0.21)
✨ 🆕 app/client/src/sagas/WidgetOperationUtils.ts 68.75 44.44 50 66.67
🟢 app/client/src/selectors/applicationSelectors.tsx 75.34 (1.37) 59.09 (0) 63.64 (4.55) 70.18 (0)
🟢 app/client/src/selectors/dataTreeSelectors.ts 66.67 (14.82) 30 (30) 33.33 (33.33) 60.87 (13.04)
🟢 app/client/src/selectors/editorSelectors.tsx 45.38 (4.61) 5.71 (5.71) 7.14 (4.76) 41.12 (5.61)
🟢 app/client/src/selectors/entitiesSelector.ts 37.26 (1.88) 1.39 (1.39) 3.95 (3.95) 33.33 (1.88)
🟢 app/client/src/selectors/propertyPaneSelectors.tsx 48 (12) 20 (20) 60 (60) 50 (12.5)
🟢 app/client/src/selectors/themeSelectors.tsx 88.24 (11.77) 75 (25) 60 (20) 91.67 (16.67)
🟢 app/client/src/utils/AppsmithUtils.tsx 46.59 (2.27) 13.41 (2.43) 33.33 (5.55) 40.52 (2.61)
🟢 app/client/src/utils/WidgetPropsUtils.tsx 18.34 (0.69) 0.81 (0.81) 2.5 (2.5) 15.19 (0.75)
🟢 app/client/src/utils/generators.tsx 76.19 (4.76) 33.33 (0) 50 (25) 76.92 (7.69)
🟢 app/client/src/utils/helpers.tsx 39.37 (0.66) 5.26 (0) 4.35 (-0.2) 30 (0.41)
🟢 app/client/src/utils/autocomplete/EntityDefinitions.ts 46.67 (3.81) 0 (0) 25 (25) 46.67 (3.81)
🟢 app/client/src/utils/hooks/dragResizeHooks.tsx 45.83 (12.5) 0 (0) 18.75 (18.75) 40 (15)
🟢 app/client/src/utils/hooks/useClickOpenPropPane.tsx 80 (48) 0 (0) 80 (80) 82.61 (52.18)
🟢 app/client/src/widgets/BaseWidget.tsx 73.79 (29.67) 33.33 (33.33) 51.85 (48.15) 72.45 (26.53)
✨ 🆕 app/client/src/widgets/MetaHOC.tsx 20 0 15.38 21.57
✨ 🆕 app/client/src/widgets/ListWidget/ListComponent.tsx 71.43 75 25 71.43
✨ 🆕 app/client/src/widgets/ListWidget/ListPagination.tsx 70 33.33 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPropertyPaneConfig.ts 60 100 0 60
✨ 🆕 app/client/src/widgets/ListWidget/ListWidget.tsx 37.19 21.18 17.65 36.22
🟢 app/client/src/workers/validations.ts 44.1 (2.77) 36.53 (2.31) 47.73 (3.83) 43.93 (2.53)

@github-actions
Copy link

Test coverage results 🧪

Code coverage diff between base branch:release and head branch: feature/list-grid-widget
Status File % Stmts % Branch % Funcs % Lines
🟢 total 47.88 (2.5) 30.07 (2.72) 26.3 (4.92) 48.02 (2.41)
✨ 🆕 app/client/src/actions/apiPaneActions.ts 68 100 0 52.94
🟢 app/client/src/actions/propertyPaneActions.ts 85.71 (10.71) 100 (0) 50 (50) 80 (13.33)
🟢 app/client/src/components/ads/Icon.tsx 57.69 (1.1) 36.99 (1.37) 100 (0) 57.46 (1.11)
🟢 app/client/src/components/ads/ScrollIndicator.tsx 82.22 (64.44) 53.13 (40.63) 86.67 (86.67) 78.38 (56.76)
🟢 app/client/src/components/ads/Tooltip.tsx 100 (14.29) 100 (100) 100 (100) 100 (14.29)
🟢 app/client/src/components/designSystems/appsmith/PositionedContainer.tsx 100 (33.33) 80 (60) 100 (100) 100 (35.71)
🟢 app/client/src/components/editorComponents/DragLayerComponent.tsx 71.43 (48.35) 30 (25.24) 84.62 (84.62) 69.23 (44.23)
🟢 app/client/src/components/editorComponents/DraggableComponent.tsx 72.88 (51.45) 41.03 (30.5) 53.33 (53.33) 71.7 (48.17)
🟢 app/client/src/components/editorComponents/DropTargetComponent.tsx 18 (1.67) 2.53 (-0.14) 0 (0) 19.1 (0.92)
🟢 app/client/src/components/editorComponents/ErrorBoundry.tsx 76.19 (19.05) 87.5 (37.5) 42.86 (28.57) 73.68 (15.79)
🟢 app/client/src/components/editorComponents/ResizableComponent.tsx 55.56 (34.57) 15.25 (15.25) 55.56 (55.56) 54.43 (32.91)
🟢 app/client/src/components/editorComponents/ResizeStyledComponents.tsx 100 (5.26) 96.43 (3.57) 100 (100) 100 (5.26)
🟢 app/client/src/components/editorComponents/CodeEditor/BindingPrompt.tsx 85 (55) 64.29 (35.72) 100 (100) 85 (55)
🟢 app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx 71.67 (36.67) 60.87 (29.05) 52.38 (52.38) 70.18 (35.09)
🟢 app/client/src/components/editorComponents/CodeEditor/index.tsx 47.87 (23.81) 23.42 (23.42) 26.67 (23.34) 48.59 (23.59)
🟢 app/client/src/components/editorComponents/CodeEditor/styledComponents.ts 92.42 (77.27) 56.7 (48.45) 100 (100) 95.31 (79.68)
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/LightningMenuTrigger.tsx 88.24 54.55 90 86.21
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/helpers.tsx 58.82 25 20 53.33
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/hooks.ts 76.92 25 50 73.91
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/index.tsx 91.3 0 66.67 90
🟢 app/client/src/components/editorComponents/WidgetNameComponent/SettingsControl.tsx 92.59 (25.92) 76.92 (15.38) 100 (83.33) 92.31 (26.93)
🟢 app/client/src/components/editorComponents/WidgetNameComponent/index.tsx 77.78 (51.11) 60 (46.67) 88.89 (88.89) 78.57 (52.38)
🟢 app/client/src/constants/DefaultTheme.tsx 88.78 (10.21) 88.89 (8.33) 60.71 (3.57) 86.59 (6.1)
🟢 app/client/src/constants/IconConstants.tsx 100 (0) 92.86 (14.29) 100 (0) 100 (0)
🟢 app/client/src/constants/messages.ts 69.32 (1.58) 100 (0) 7.78 (4.77) 72.08 (0.23)
🟢 app/client/src/icons/ControlIcons.tsx 53.01 (1.2) 100 (0) 2.5 (2.5) 53.01 (1.2)
🟢 app/client/src/icons/WidgetIcons.tsx 54.17 (2) 100 (0) 4.35 (4.35) 54.17 (2)
🟢 app/client/src/mockResponses/WidgetConfigResponse.tsx 28 (-7.29) 9.38 (9.38) 28.57 (28.57) 27.78 (-7.51)
🟢 app/client/src/pages/Editor/Popper.tsx 65.12 (30.24) 28.26 (19.56) 44.44 (44.44) 64.29 (30.96)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/StyledComponents.tsx 32 46.15 5.56 32
🟢 app/client/src/pages/common/CustomizedDropdown/dropdownHelpers.tsx 39.29 (7.15) 6.67 (6.67) 33.33 (33.33) 37.04 (7.41)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/index.tsx 79.41 42.86 83.33 77.42
🟢 app/client/src/resizable/index.tsx 45.76 (30.51) 35 (25) 31.58 (31.58) 45.83 (27.08)
🟢 app/client/src/sagas/WidgetBlueprintSagas.ts 30.36 (5.36) 3.13 (-5.57) 11.11 (-3.18) 34 (4.37)
✨ 🆕 app/client/src/sagas/WidgetBlueprintSagasEnums.ts 100 100 100 100
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 7.63 (-0.17) 1.02 (-0.05) 3.23 (0.06) 8.75 (-0.18)
✨ 🆕 app/client/src/sagas/WidgetOperationUtils.ts 72.22 60 57.14 70
🟢 app/client/src/selectors/applicationSelectors.tsx 75.34 (1.37) 59.09 (0) 63.64 (4.55) 70.18 (0)
🟢 app/client/src/selectors/dataTreeSelectors.ts 66.67 (14.82) 30 (30) 33.33 (33.33) 60.87 (13.04)
🟢 app/client/src/selectors/editorSelectors.tsx 45.38 (4.61) 5.71 (5.71) 7.14 (4.76) 41.12 (5.61)
🟢 app/client/src/selectors/entitiesSelector.ts 37.26 (1.88) 1.39 (1.39) 3.95 (3.95) 33.33 (1.88)
🟢 app/client/src/selectors/propertyPaneSelectors.tsx 48 (12) 20 (20) 60 (60) 50 (12.5)
🟢 app/client/src/selectors/themeSelectors.tsx 88.24 (11.77) 75 (25) 60 (20) 91.67 (16.67)
🟢 app/client/src/utils/AppsmithUtils.tsx 46.59 (2.27) 13.41 (2.43) 33.33 (5.55) 40.52 (2.61)
🟢 app/client/src/utils/WidgetPropsUtils.tsx 18.34 (0.69) 0.81 (0.81) 2.5 (2.5) 15.19 (0.75)
🟢 app/client/src/utils/generators.tsx 76.19 (4.76) 33.33 (0) 50 (25) 76.92 (7.69)
🟢 app/client/src/utils/helpers.tsx 39.37 (0.66) 5.26 (0) 4.35 (-0.2) 30 (0.41)
🟢 app/client/src/utils/autocomplete/EntityDefinitions.ts 46.67 (3.81) 0 (0) 25 (25) 46.67 (3.81)
🟢 app/client/src/utils/hooks/dragResizeHooks.tsx 45.83 (12.5) 0 (0) 18.75 (18.75) 40 (15)
🟢 app/client/src/utils/hooks/useClickOpenPropPane.tsx 80 (48) 0 (0) 80 (80) 82.61 (52.18)
🟢 app/client/src/widgets/BaseWidget.tsx 73.79 (29.67) 33.33 (33.33) 51.85 (48.15) 72.45 (26.53)
✨ 🆕 app/client/src/widgets/MetaHOC.tsx 20 0 15.38 21.57
✨ 🆕 app/client/src/widgets/ListWidget/ListComponent.tsx 71.43 75 25 71.43
✨ 🆕 app/client/src/widgets/ListWidget/ListPagination.tsx 70 33.33 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPropertyPaneConfig.ts 60 100 0 60
✨ 🆕 app/client/src/widgets/ListWidget/ListWidget.tsx 37.19 21.18 17.65 36.22
🟢 app/client/src/workers/validations.ts 44.1 (2.77) 36.53 (2.31) 47.73 (3.83) 43.93 (2.53)

@github-actions
Copy link

Test coverage results 🧪

Code coverage diff between base branch:release and head branch: feature/list-grid-widget
Status File % Stmts % Branch % Funcs % Lines
🟢 total 47.88 (2.5) 30.07 (2.72) 26.3 (4.92) 48.02 (2.41)
✨ 🆕 app/client/src/actions/apiPaneActions.ts 68 100 0 52.94
🟢 app/client/src/actions/propertyPaneActions.ts 85.71 (10.71) 100 (0) 50 (50) 80 (13.33)
🟢 app/client/src/components/ads/Icon.tsx 57.69 (1.1) 36.99 (1.37) 100 (0) 57.46 (1.11)
🟢 app/client/src/components/ads/ScrollIndicator.tsx 82.22 (64.44) 53.13 (40.63) 86.67 (86.67) 78.38 (56.76)
🟢 app/client/src/components/ads/Tooltip.tsx 100 (14.29) 100 (100) 100 (100) 100 (14.29)
🟢 app/client/src/components/designSystems/appsmith/PositionedContainer.tsx 100 (33.33) 80 (60) 100 (100) 100 (35.71)
🟢 app/client/src/components/editorComponents/DragLayerComponent.tsx 71.43 (48.35) 30 (25.24) 84.62 (84.62) 69.23 (44.23)
🟢 app/client/src/components/editorComponents/DraggableComponent.tsx 72.88 (51.45) 41.03 (30.5) 53.33 (53.33) 71.7 (48.17)
🟢 app/client/src/components/editorComponents/DropTargetComponent.tsx 18 (1.67) 2.53 (-0.14) 0 (0) 19.1 (0.92)
🟢 app/client/src/components/editorComponents/ErrorBoundry.tsx 76.19 (19.05) 87.5 (37.5) 42.86 (28.57) 73.68 (15.79)
🟢 app/client/src/components/editorComponents/ResizableComponent.tsx 55.56 (34.57) 15.25 (15.25) 55.56 (55.56) 54.43 (32.91)
🟢 app/client/src/components/editorComponents/ResizeStyledComponents.tsx 100 (5.26) 96.43 (3.57) 100 (100) 100 (5.26)
🟢 app/client/src/components/editorComponents/CodeEditor/BindingPrompt.tsx 85 (55) 64.29 (35.72) 100 (100) 85 (55)
🟢 app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx 71.67 (36.67) 60.87 (29.05) 52.38 (52.38) 70.18 (35.09)
🟢 app/client/src/components/editorComponents/CodeEditor/index.tsx 47.87 (23.81) 23.42 (23.42) 26.67 (23.34) 48.59 (23.59)
🟢 app/client/src/components/editorComponents/CodeEditor/styledComponents.ts 92.42 (77.27) 56.7 (48.45) 100 (100) 95.31 (79.68)
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/LightningMenuTrigger.tsx 88.24 54.55 90 86.21
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/helpers.tsx 58.82 25 20 53.33
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/hooks.ts 76.92 25 50 73.91
✨ 🆕 app/client/src/components/editorComponents/LightningMenu/index.tsx 91.3 0 66.67 90
🟢 app/client/src/components/editorComponents/WidgetNameComponent/SettingsControl.tsx 92.59 (25.92) 76.92 (15.38) 100 (83.33) 92.31 (26.93)
🟢 app/client/src/components/editorComponents/WidgetNameComponent/index.tsx 77.78 (51.11) 60 (46.67) 88.89 (88.89) 78.57 (52.38)
🟢 app/client/src/constants/DefaultTheme.tsx 88.78 (10.21) 88.89 (8.33) 60.71 (3.57) 86.59 (6.1)
🟢 app/client/src/constants/IconConstants.tsx 100 (0) 92.86 (14.29) 100 (0) 100 (0)
🟢 app/client/src/constants/messages.ts 69.32 (1.58) 100 (0) 7.78 (4.77) 72.08 (0.23)
🟢 app/client/src/icons/ControlIcons.tsx 53.01 (1.2) 100 (0) 2.5 (2.5) 53.01 (1.2)
🟢 app/client/src/icons/WidgetIcons.tsx 54.17 (2) 100 (0) 4.35 (4.35) 54.17 (2)
🟢 app/client/src/mockResponses/WidgetConfigResponse.tsx 28 (-7.29) 9.38 (9.38) 28.57 (28.57) 27.78 (-7.51)
🟢 app/client/src/pages/Editor/Popper.tsx 65.12 (30.24) 28.26 (19.56) 44.44 (44.44) 64.29 (30.96)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/StyledComponents.tsx 32 46.15 5.56 32
🟢 app/client/src/pages/common/CustomizedDropdown/dropdownHelpers.tsx 39.29 (7.15) 6.67 (6.67) 33.33 (33.33) 37.04 (7.41)
✨ 🆕 app/client/src/pages/common/CustomizedDropdown/index.tsx 79.41 42.86 83.33 77.42
🟢 app/client/src/resizable/index.tsx 45.76 (30.51) 35 (25) 31.58 (31.58) 45.83 (27.08)
🟢 app/client/src/sagas/WidgetBlueprintSagas.ts 30.36 (5.36) 3.13 (-5.57) 11.11 (-3.18) 34 (4.37)
✨ 🆕 app/client/src/sagas/WidgetBlueprintSagasEnums.ts 100 100 100 100
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 7.63 (-0.17) 1.02 (-0.05) 3.23 (0.06) 8.75 (-0.18)
✨ 🆕 app/client/src/sagas/WidgetOperationUtils.ts 72.22 60 57.14 70
🟢 app/client/src/selectors/applicationSelectors.tsx 75.34 (1.37) 59.09 (0) 63.64 (4.55) 70.18 (0)
🟢 app/client/src/selectors/dataTreeSelectors.ts 66.67 (14.82) 30 (30) 33.33 (33.33) 60.87 (13.04)
🟢 app/client/src/selectors/editorSelectors.tsx 45.38 (4.61) 5.71 (5.71) 7.14 (4.76) 41.12 (5.61)
🟢 app/client/src/selectors/entitiesSelector.ts 37.26 (1.88) 1.39 (1.39) 3.95 (3.95) 33.33 (1.88)
🟢 app/client/src/selectors/propertyPaneSelectors.tsx 48 (12) 20 (20) 60 (60) 50 (12.5)
🟢 app/client/src/selectors/themeSelectors.tsx 88.24 (11.77) 75 (25) 60 (20) 91.67 (16.67)
🟢 app/client/src/utils/AppsmithUtils.tsx 46.59 (2.27) 13.41 (2.43) 33.33 (5.55) 40.52 (2.61)
🟢 app/client/src/utils/WidgetPropsUtils.tsx 18.34 (0.69) 0.81 (0.81) 2.5 (2.5) 15.19 (0.75)
🟢 app/client/src/utils/generators.tsx 76.19 (4.76) 33.33 (0) 50 (25) 76.92 (7.69)
🟢 app/client/src/utils/helpers.tsx 39.37 (0.66) 5.26 (0) 4.35 (-0.2) 30 (0.41)
🟢 app/client/src/utils/autocomplete/EntityDefinitions.ts 46.67 (3.81) 0 (0) 25 (25) 46.67 (3.81)
🟢 app/client/src/utils/hooks/dragResizeHooks.tsx 45.83 (12.5) 0 (0) 18.75 (18.75) 40 (15)
🟢 app/client/src/utils/hooks/useClickOpenPropPane.tsx 80 (48) 0 (0) 80 (80) 82.61 (52.18)
🟢 app/client/src/widgets/BaseWidget.tsx 73.79 (29.67) 33.33 (33.33) 51.85 (48.15) 72.45 (26.53)
✨ 🆕 app/client/src/widgets/MetaHOC.tsx 20 0 15.38 21.57
✨ 🆕 app/client/src/widgets/ListWidget/ListComponent.tsx 71.43 75 25 71.43
✨ 🆕 app/client/src/widgets/ListWidget/ListPagination.tsx 70 33.33 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPropertyPaneConfig.ts 60 100 0 60
✨ 🆕 app/client/src/widgets/ListWidget/ListWidget.tsx 37.19 21.18 17.65 36.22
🟢 app/client/src/workers/validations.ts 44.1 (2.77) 36.53 (2.31) 47.73 (3.83) 43.93 (2.53)

@riodeuno riodeuno marked this pull request as ready for review April 22, 2021 06:30
riodeuno
riodeuno previously approved these changes Apr 22, 2021
View reviewed changes
riodeuno
riodeuno previously approved these changes Apr 22, 2021
View reviewed changes
@github-actions
Copy link

Test coverage results 🧪

Code coverage diff between base branch:release and head branch: feature/list-grid-widget
Status File % Stmts % Branch % Funcs % Lines
🟢 total 48.72 (1.62) 30.94 (1.63) 27.38 (3.29) 48.87 (1.57)
🟢 app/client/src/actions/propertyPaneActions.ts 85.71 (10.71) 100 (0) 50 (50) 80 (13.33)
🟢 app/client/src/components/ads/Icon.tsx 57.69 (1.1) 36.99 (1.37) 100 (0) 57.46 (1.11)
🟢 app/client/src/components/ads/ScrollIndicator.tsx 82.22 (0) 53.13 (3.13) 86.67 (0) 78.38 (0)
🟢 app/client/src/components/ads/Tooltip.tsx 100 (14.29) 100 (100) 100 (100) 100 (14.29)
🟢 app/client/src/components/designSystems/appsmith/PositionedContainer.tsx 100 (33.33) 80 (60) 100 (100) 100 (35.71)
🟢 app/client/src/components/editorComponents/DragLayerComponent.tsx 71.43 (48.35) 30 (25.24) 84.62 (84.62) 69.23 (44.23)
🟢 app/client/src/components/editorComponents/DraggableComponent.tsx 72.88 (51.45) 41.03 (30.5) 53.33 (53.33) 71.7 (48.17)
🟢 app/client/src/components/editorComponents/DropTargetComponent.tsx 18 (1.67) 2.53 (-0.14) 0 (0) 19.1 (0.92)
🟢 app/client/src/components/editorComponents/ErrorBoundry.tsx 76.19 (19.05) 87.5 (37.5) 42.86 (28.57) 73.68 (15.79)
🟢 app/client/src/components/editorComponents/ResizableComponent.tsx 55.56 (34.57) 15.25 (15.25) 55.56 (55.56) 54.43 (32.91)
🟢 app/client/src/components/editorComponents/ResizeStyledComponents.tsx 100 (5.26) 96.43 (3.57) 100 (100) 100 (5.26)
🟢 app/client/src/components/editorComponents/CodeEditor/EvaluatedValuePopup.tsx 76.67 (25) 65.22 (22.04) 52.38 (47.62) 75.44 (26.32)
🟢 app/client/src/components/editorComponents/CodeEditor/index.tsx 73.4 (0.14) 53.15 (2.7) 56.67 (0) 73.45 (0.15)
🟢 app/client/src/components/editorComponents/LightningMenu/LightningMenuTrigger.tsx 88.24 (58.83) 54.55 (45.46) 90 (90) 86.21 (55.18)
🟢 app/client/src/components/editorComponents/LightningMenu/helpers.tsx 58.82 (14.7) 25 (25) 20 (20) 53.33 (16.66)
🟢 app/client/src/components/editorComponents/LightningMenu/hooks.ts 73.33 (46.66) 25 (25) 42.86 (42.86) 70.37 (51.85)
🟢 app/client/src/components/editorComponents/LightningMenu/index.tsx 91.67 (41.67) 0 (0) 66.67 (66.67) 90 (35)
🟢 app/client/src/components/editorComponents/WidgetNameComponent/SettingsControl.tsx 92.59 (25.92) 76.92 (15.38) 100 (83.33) 92.31 (26.93)
🟢 app/client/src/components/editorComponents/WidgetNameComponent/index.tsx 77.78 (51.11) 60 (46.67) 88.89 (88.89) 78.57 (52.38)
🟢 app/client/src/constants/DefaultTheme.tsx 88.78 (10.21) 88.89 (8.33) 60.71 (3.57) 86.59 (6.1)
🟢 app/client/src/constants/IconConstants.tsx 100 (0) 92.86 (14.29) 100 (0) 100 (0)
🟢 app/client/src/constants/messages.ts 69.57 (1.58) 100 (0) 7.78 (4.77) 72.54 (0.23)
🟢 app/client/src/icons/ControlIcons.tsx 53.01 (1.2) 100 (0) 2.5 (2.5) 53.01 (1.2)
🟢 app/client/src/icons/WidgetIcons.tsx 54.17 (2) 100 (0) 4.35 (4.35) 54.17 (2)
🟢 app/client/src/mockResponses/WidgetConfigResponse.tsx 28 (-7.29) 9.38 (9.38) 28.57 (28.57) 27.78 (-7.51)
🟢 app/client/src/pages/Editor/Popper.tsx 65.12 (30.24) 28.26 (19.56) 44.44 (44.44) 64.29 (30.96)
🟢 app/client/src/pages/common/CustomizedDropdown/StyledComponents.tsx 32 (4) 46.15 (7.69) 5.56 (5.56) 32 (4)
🟢 app/client/src/pages/common/CustomizedDropdown/dropdownHelpers.tsx 39.29 (7.15) 6.67 (6.67) 33.33 (33.33) 37.04 (7.41)
🟢 app/client/src/pages/common/CustomizedDropdown/index.tsx 79.41 (29.41) 42.86 (42.86) 83.33 (83.33) 77.42 (29.03)
🟢 app/client/src/resizable/index.tsx 45.76 (30.51) 35 (25) 31.58 (31.58) 45.83 (27.08)
🟢 app/client/src/sagas/WidgetBlueprintSagas.ts 30.36 (5.36) 3.13 (-5.57) 11.11 (-3.18) 34 (4.37)
✨ 🆕 app/client/src/sagas/WidgetBlueprintSagasEnums.ts 100 100 100 100
🔴 app/client/src/sagas/WidgetOperationSagas.tsx 7.63 (-0.17) 1.02 (-0.05) 3.23 (0.06) 8.75 (-0.18)
✨ 🆕 app/client/src/sagas/WidgetOperationUtils.ts 72.22 60 57.14 70
🟢 app/client/src/selectors/applicationSelectors.tsx 75.34 (1.37) 59.09 (0) 63.64 (4.55) 70.18 (0)
🟢 app/client/src/selectors/editorSelectors.tsx 44.88 (4.72) 5.71 (5.71) 7.32 (4.88) 40.95 (5.71)
🟢 app/client/src/selectors/propertyPaneSelectors.tsx 48 (12) 20 (20) 60 (60) 50 (12.5)
🟢 app/client/src/selectors/themeSelectors.tsx 88.24 (11.77) 75 (25) 60 (20) 91.67 (16.67)
🟢 app/client/src/utils/WidgetPropsUtils.tsx 18.34 (0.69) 0.81 (0.81) 2.5 (2.5) 15.19 (0.75)
🟢 app/client/src/utils/generators.tsx 76.19 (4.76) 33.33 (0) 50 (25) 76.92 (7.69)
🟢 app/client/src/utils/helpers.tsx 39.37 (0.66) 5.26 (0) 4.35 (-0.2) 30 (0.41)
🟢 app/client/src/utils/autocomplete/EntityDefinitions.ts 46.67 (3.81) 0 (0) 25 (25) 46.67 (3.81)
🟢 app/client/src/utils/hooks/dragResizeHooks.tsx 45.83 (12.5) 0 (0) 18.75 (18.75) 40 (15)
🟢 app/client/src/utils/hooks/useClickOpenPropPane.tsx 80 (48) 0 (0) 80 (80) 82.61 (52.18)
🟢 app/client/src/widgets/BaseWidget.tsx 74 (30.57) 33.33 (33.33) 53.85 (50) 72.63 (27.37)
✨ 🆕 app/client/src/widgets/MetaHOC.tsx 20 0 15.38 21.57
✨ 🆕 app/client/src/widgets/ListWidget/ListComponent.tsx 71.43 75 25 71.43
✨ 🆕 app/client/src/widgets/ListWidget/ListPagination.tsx 70 33.33 0 70
✨ 🆕 app/client/src/widgets/ListWidget/ListPropertyPaneConfig.ts 66.67 100 0 66.67
✨ 🆕 app/client/src/widgets/ListWidget/ListWidget.tsx 36.41 21.18 18.18 35.36
🟢 app/client/src/workers/validations.ts 36.52 (2.99) 29.89 (2.51) 38.64 (4.49) 36.14 (2.7)

@jsartisan jsartisan merged commit 1717b0e into release Apr 23, 2021
@jsartisan jsartisan deleted the feature/list-grid-widget branch April 23, 2021 05:43
@jsartisan jsartisan mentioned this pull request Apr 28, 2021
Merged
rishabhrathod01
rishabhrathod01 reviewed Mar 1, 2022
View reviewed changes
app/client/src/widgets/ListWidget/ListWidget.tsx
Comment on lines +261 to +264
prev +
`{{((currentItem) => { ${next}})(JSON.parse('${JSON.stringify(
listItem,
)}'))}}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON.stringify logic was added here.

@Nikhil-Nandagopal Nikhil-Nandagopal mentioned this pull request Jul 29, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhrathod01 rishabhrathod01 rishabhrathod01 left review comments

@riodeuno riodeuno riodeuno approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic] List/Grid Widget
6 participants
@jsartisan @riodeuno @rishabhrathod01 @ofpiyush @vicky-primathon @hetunandu