List Widget Phase 2 #4189
Merged
List Widget Phase 2 #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/list-widget-phase-2
|
A reviewer left a comment: Why does the all items apart from the 1 item look disabled by default? I don't see such configurations Browser metadata |
added 10 commits
June 16, 2021 11:49
marks0351
previously approved these changes
Jun 17, 2021
added 2 commits
June 17, 2021 21:57
…e/list-widget-phase-2
marks0351
previously approved these changes
Jun 17, 2021
somangshu
approved these changes
Jun 18, 2021
10 tasks
This was referenced Jun 21, 2021
ayushpahwa
added a commit
that referenced
this pull request
Jun 30, 2021
* fix: reduced portal zindex * fix: move dropdown options to portal * fix: overlay covering widget explorer * Fix: modal and Dropdown * fix: remove unnecessary className * fix: remove console statement * FEATURE-2111 : Show/Hide Table Controls -- Add the header options section for the visibility setting -- Render conditionally the header part based on the setting * FEATURE-2111 : Show/Hide Table Controls -- Remove JS convertible -- Set isBindProperty and isTriggerProperty to false * FEATURE-2111 : Show/Hide Table Controls -- PositionedContainer : Add padding-bottom: 42px in case of Table widget * FEATURE-2111 : Show/Hide Table Controls -- Remove extra space when the header options is all hidden * Revert "FEATURE-2111 : Show/Hide Table Controls" This reverts commit 1d3c2da. * FEATURE-2111 : Show/Hide table controls -- Apply some cleanup * FEATURE-2111 : Show/Hide Table Controls -- Adjust pageSize -- Change column header height -- Restore the logic for renderEmptyRow * fix: PR comments * fix: failing modal test * fix: add Layers to the dropdown * fix: Add zIndex Layers of Dropdown and Modal * - Change useEffect hook to use deep cehck for modifiers instead of refernece equality - Moemoize getThemeDetails * FIX #4731: update condition for selectedRowIndices when table widget drag and drop * FEATURE-2111 : Show/Hide Table Controls -- Use isHeaderVisible variable for conditional rendering * FIX #4875 : update modal onclick reference for same modal while pasting modal and added test case * Add API for setting page order in an application * fix: options display in deploy view * - Close the property pane at the start of the test as it's not closed in the earlier test case. * FEATURE-1726 : iframe widget -- Scaffold the widget -- Bind properties * Add API for setting page order in an application * FEATURE-2111 : Show/Hide Table Controls -- Add a migration for the header options visibilities * FEATURE-1726 : Iframe Widget -- Bind onURLChanged event listener * Add page re-order API * Add page re-order API * FEATURE-1726 : Iframe Widget -- Bind onMessageReceived -- Refactor event bindings * Moved constructor to the top. * FEATURE-1726 : Iframe widget -- Remove spread operator on IframeComponent -- Use a theme color by default for border color -- Fix the crash issue when the widget is removed * FEATURE-1726 : Iframe Widget -- Remove the spread operator in IframeWidget -- Connect the widget help with the correct documentation path -- Expose source and title for autocomplete -- Remove the redundant wrapping with meta from the widget * 1. Added logic to handle pageDown scenario 2. Added comments * Add test for page reorder and add order to the response * Check if user exists before loading the form (#5108) * Updated fork/duplicate test (#4923) * Updated test to handle version * updated test * added a small wait * Assertion updated * formatted code * fork test updated * dsl file added * Updated test * Try waiting in the addDsl step * Other fixes Co-authored-by: hetunandu <[email protected]> * Use assertThat type of assertions and move the order initialization logic to migration * updated test flow (#5118) * Fix: Use connection pool for Redis (#5093) * Replace single connection instance with a connection pool. This will ensure that simultaneous actions don't fail / break the connection. * Fix/api editor enhancement (#5095) * Keep datasource tab open when there are datasources configured in API editor * Save headers when users save an action as datasource * Fix incorrect action type reference (#5121) * Update config.json * Button UI Test Cases. Automated following UI test cases for button regarding the property pane: Button Style Validation Button Copy and paste Button Delete Create api, and then call it upon clicking the button widget. Create query, and then call it upon clicking the button widget. All above using JS * JS Scenario * Allow only organization admins to export application (#5085) * Added permission export:applications for admin role * Only admins are allowed to export applications Co-authored-by: Pranav Kanade <[email protected]> * Add an option to set tags on transactions #5147 * 1. Add migration logic 2. Add order while creating pages * - Set the default perfTags value to [] * - Fix typo in type definitions * 1. Fix failing unit tests for the page reorder * Modifying PR template to revert to older version (#5154) * [Feature] Smart Substitution for JSON fields in Mongo Form (#5136) * Reduced verbosity of the command names for Insert, Find and Delete * WIP : Smart substitution untested changes for mongo form * Tested code for smart substitution working for mongo form fields * Added test case for assert for smart substitution * Fix merge conficts * Cypress.json update * Deleted Hard Waits. Deleted Hard Waits. * Change the test scenario * fix for #5073 * Added Documentation for Windows WSL2 Client Setup * Fix: updating basic dsl for fork and duplicate feature cypress specs (#5152) * dip * dip * Resolved Conflict in QueryEditor.json file Resolved Conflict in QueryEditor.json file * Changing instruction for better setup * Ignore the order of the page while checking the published and edited pages test * Feature/signup success url (#5124) * Reset the user in store on 401s (#5153) * Fature/add pagination in notifications (#5096) * -added pagination to notifications API * -add unit tests for notification pagination * -added unread count in get notifications API * -moved notification creations to notification service from comment service * -add repository method to mark a notification as read * -added repository to update isRead by for username * -add API to mark notification as read * -addd application id and application name in notification * -save application id and name in notification when creating notification for comment and comment threads * -added page id, from user information in notifications * -fixed failing unit test due to dependency error * -removed unused imports * -extended base controller in notification controller * - introduced pagination based on before created data instead of offset based pagination * -moved application id, name and page id inside comment from notification * -moved author information from notification to comment thread * -return data from notification service instead of the response object in the mark read or unread API * - Remove the is_array check * Profile image updates (#4783) * Fix: parse json/jsonb data type values as json for postgres plugin (#5135) * parse json/jsonb data type values as json * add support for json (non binary, earlier support for jsonb was added) * Highlight the second item in in the omnibar search results (#4611) * Comments feature fixes (view mode) (#5081) * Snowflake integration (#5176) * POC for snowflake integration with Appsmith This is just a rough version to see if the functionality works. Needs to be cleaned up & enhanced for production usage. * Plugin with connection, monos, ds testing, validation, templates, structure and forms * Better comments * Default schema to public * Changed logging destination, populated request in result and used thread group for datasource creation Co-authored-by: Arpit Mohan <[email protected]> * Add widget ID, widget type to property pane open perforamnce tracker. * removed unwanted wait (#5206) * Feature: Widget Grouping Phase II (#4825) * dip * dip * Cleaning up grid density positioning. * dip * dip * dip * dip * code clean up * dip * dip(restructuring widget selection) * Deselect parents and children of a widget when user multi selects. * dip * dip * dip * dip * dip * fixing a bad merge * fixing tests * adding jest tests. * common util * dip * dip * fixes * restrict in deploy mode. * fixing dynamic layout. * fixing tests. * on paste fix. * fixing specs. * addressing code review comments * dip * dip * dip * fixing specs. * fix: app/server/appsmith-interfaces/pom.xml & app/server/appsmith-server/pom.xml to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052449 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052450 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1054588 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056414 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056416 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056417 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056418 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056419 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056420 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056421 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056424 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056425 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056426 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056427 - https://snyk.io/vuln/SNYK-JAVA-COMMONSBEANUTILS-460111 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1020439 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1070799 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1082238 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1083991 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1089809 - https://snyk.io/vuln/SNYK-JAVA-IOPROJECTREACTORNETTY-559154 - https://snyk.io/vuln/SNYK-JAVA-IOPROJECTREACTORNETTY-559155 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1009832 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1296829 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORKSECURITY-1290497 - https://snyk.io/vuln/SNYK-JAVA-ORGYAML-537645 * Fix: Show error callout in api pane when there is an error (#4827) * Fixed and updated Button Specs. Fixed "Button-Call-Query Validation" test case in Button Spec and updated Copy, delete widget test cases. * Add commands in Command.js Add commands in Command.js copyWidget, deleteWidget * Fix app publish event sent at wrong times * Fix redirect URL on 401s (#5230) * Support for orphan API without any datasource added for import-export functionality (#5232) * Remove * import statements * Update README.md * Typo * Another typo 🤦🏻♂️ * [Snyk] Security upgrade net.minidev:json-smart from 2.3 to 2.4.7 (#5225) * fix: app/server/appsmith-interfaces/pom.xml to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-NETMINIDEV-1078499 - https://snyk.io/vuln/SNYK-JAVA-NETMINIDEV-1298655 * Updating the json-smart dependency to the latest one Co-authored-by: Arpit Mohan <[email protected]> * Merge the two update commands into a single update command in Mongo Form (#5171) * Update commands have been merged into a single update command for both single and multi updates * Added migrations to migrate any update one mongo form command to new update command * Incorporated review comments * Schema info in templates query (#5244) * Commenting out migration for quick fix to bring up release (#5248) * List Widget Phase 2 (#4189) * update meta properties + default properties map * update widget registery * update get meta property * update metahoc + widgetfactory + data tree evaluator * try sending function as string to worker * revert data tree evaluator update * pass default props map from dataTreeWidget file * wip * save child meta properties * remove console.log * save meta and default map in list * update listwidget * remove console.log + unused variables * revert getMetaPropertiesMap function * fix data tree test * fix list widget test * fix entity definition test * fix overriting of item in updatedItems * remove todo comments * fix meta prop issue * revert making meta properties from undefiend to "" & fix filepicker bug * fix test case * change items to listData and updatedItems to items * remove console.log * fix test * extract derived properties to dervied.js * disabled top, left, right resize handler list widget container * add test for dervied js * add test for selectedItem * fix background color bug on hover * remove console.log * fix chart widget inside list widget * fix checkbox issue + points raised by yogesh * revert the createImmerReducer usage * fix parse derived properties * remove internal props object that fails the test * fix import typo * allow bottom resize handler * fix template height check * fix template height check * update template size check * fix the is visible invalid prop issue * fix migration of list widget phase 2 * fix migration * remove unused import * fix migration * fix migration * remove console.log * hide delete option for container in entity explorer * fix testcases * remove unused import * fix switch widget meta prop Co-authored-by: root <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> * Fix publish application event not being sent * Change the logic to have check for the order of all the pages * Fix Table Widget Filter issue (#3975) * Fix issue where non-string empty values are not correctly filtered * Add unit test for fix * Updated Widgets_form_input_table_default_validation.js Updated Widgets_form_input_table_default_validation.js * update gifs on readme * Change the test method name to more meaningful,.equals for boolean comparision, fix indentation * Migration for createdAt and updatedAt field for userCollection if not present (#5249) * [ImgBot] Optimize images (#5260) *Total -- 1,360.99kb -> 1,333.59kb (2.01%) /static/animations/running-api.gif -- 1,353.80kb -> 1,326.48kb (2.02%) /app/client/src/assets/images/InspectElement.svg -- 4.50kb -> 4.43kb (1.46%) /app/client/src/assets/icons/comments/down-arrow.svg -- 0.32kb -> 0.32kb (1.21%) /app/client/src/assets/icons/ads/bell.svg -- 0.38kb -> 0.37kb (0.78%) /app/client/src/assets/icons/ads/upload_success.svg -- 0.48kb -> 0.48kb (0.61%) /app/client/src/assets/icons/ads/download.svg -- 0.60kb -> 0.60kb (0.49%) /app/client/src/assets/icons/comments/eye.svg -- 0.91kb -> 0.91kb (0.32%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]> * Run tests for all approved PRs (#5275) * Fix: Log dependent property values in debugger when a property is updated (#4865) * [ImgBot] Optimize images (#5277) *Total -- 3,594.44kb -> 3,429.78kb (4.58%) /static/animations/widgets.gif -- 1,349.47kb -> 1,261.08kb (6.55%) /static/animations/javascript.gif -- 2,244.10kb -> 2,167.84kb (3.4%) /app/client/src/assets/icons/comments/filter.svg -- 0.86kb -> 0.86kb (0.34%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]> * FEATURE-1726 : Iframe Widget -- Set default source url to wikipedia.org -- Fix typo on the tooltip of onURLChanged, url to URL -- Fix the issue which is related to reduced iframe in its deploy mode -- Fix the issue which is related to the inclusion of nearby widgets in deploy mode -- Add Expected Data Type fields with regard to borderOpacity and borderWidth * Generate linting errors via JSHint (#5034) * Mongo For Update Migrations (#5291) * Commenting out migration for quick fix to bring up release * Added null checks for the incomplete configured update single and update many queries * Bug Fix: Fix dynamic binding substitution failure with Firestore `where` condition input boxes. (#5280) Modify dynamic binding substitution method to handle list and map types containing generic type values. * Removed intermediate navigation to datasource list page. (#5304) * Fix to enable scroll in sql query results. (#5091) * Dynamically adjust table virtualizer's height according to resizer * Remove unused configurations in Netlify * Use loadash get function to add fall back value to datasource url (#5285) * Bump ws from 6.2.1 to 6.2.2 in /app/client (#4941) Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/commits) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added Cypress tests for tab widget (#4345) * Added tests for tab widget * Added another test * Commone method updated * commented test * Set the order to published pages * Remove the unnecessary comments * Fix cyclical dependency issue when Api returns an error (#5333) Co-authored-by: Trisha Anand <[email protected]> * Error message when updating duplicate application name modified to give more contextual information (#5341) * Feature/implement comment thread subscriber (#5261) * -send email to users who are subscribed to a thread only * -fixed null pointer exception while set subscriber in create thread * -updated as per PR comments and review * Enable total number of rows and page size for server side pagination in table widget (#4863) * Add defaultPageSize and totalRecordsCount properties in table widget * Changing next button disable * Added checks for properties change * Handle defaultPageSize change * Updated util.test to handle new table properties * Configure for cypress test for page size and total records count properties * Added cypress test for default page size and total records count validation * Fix test cases * Handle empty space for page size is less than availabe space in table widget * Minor fixes for errors (#5361) * Fixed empty area issue when columns are hidden in published mode (#5162) * Create appsmith_templates.md (#4412) * Create appsmith_templates.md * Update appsmith_templates.md * Update office_hours.md * Update README.md * Update README.md * Update appsmith_templates.md * Notification updates (#5239) * Show the associated page name subtly in the omnibar (#5120) * bug/duplicate application name error will be handled (#5316) * will show last saved app name if save app name action results in error * handled duplicate appname update for editing cards * fixed the app icon update bug * updated list widget dsl * Update comments onboarding carousel images (#5373) * Set mode for comments (#5372) * Fix bug where some fields are missing for notifications from the API (#5336) * -set createdAt and type fields in notification -add threadId in response for comment * -fixed bug with unread notification count * Minor collab fixes (#5271) * Fix: Fixes a bug in onboarding flow step 1 (#5363) * API for generating a page with UI based on the structure of a given database table (#5269) * Keymapping, Clone actions from template application, Used exported application JSON file as template app * Delete references of widgets from action config if extra widgets not required * Separate API added when pageId is not present with the client * Added TCs * Update in regex, enable reqArgsConstructor, separate DTO for CRUD page * Make the whole window scrollable instead of the main container (#5369) * Adding detailed steps on adding a new plugin (#5388) * Update links on README (#5378) * Correcting typo in plugin contribution guide * Chart UI test cases (#5370) * Chart UI Test Cases Added UI Test cases for Chart Widget. - All Chart Types - JS Scenarios - onClick Scenarios - Copy - Delete * Fixed Chart displaying issue. Fixed Chart displaying issue. * Feature: add api key based and bearer token based authentication options to REST API datasource (#5367) * add api key based and bearer token based authentication options to REST API datasource * this change is ported to release from Feature: datasource changes for api key auth, bearer token auth, combine config. #4683 * removed quotes from sql templates because of prepared statements being on (#5404) removed comments from sql templates confusing users with errors because of linting * chore: Adds Community Call for Jun 24 * Security upgrade node-sass from 4.14.1 to 6.0.1 The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TRIMNEWLINES-1298042 * Changes to show multiple messages for a log in the debugger (#5144) * [Feature] Widget Grouping Phase - 3 (Cut Copy Paste) (#5083) * Cut copy paste first cut * removed different parent groups logic * mouseup on the outer canvas removes selections. * bug fix * remove unwanted dead code. * Adding tests * build fix * min height fixes * fixing specs. * fixing specs. * Onboarding typeform related fixes (#5416) * Added pod label automation for the new iFrame widget (#5440) * Test updated as it was flaky (#5441) * Fix the comment missing issue when new users added to organization (#5314) * -Add the newly added user to existing comment threads * -update PR as per review comment * -updated the PR as per review * Manual test Ideas for GoogleSheets and Mongo DB Form Input (#4857) * FIX #4627: updated css to change button widget height when deployed (#5439) This fixes the difference in the height of a button widget between edit mode and deploy mode. * Removed Reload action (#5450) * removed Reload action * count assertion removed * Update/bump node version in the doc (#5455) * [Mongo Plugin] Raw is now a command option instead of Form vs Raw (#5446) * Raw is now a command option instead of Form vs Raw * Added database migration for migration raw input type to be of raw command type * Fixed test case failure * Minor cleanup * Updated Template * Updated Template * Updated Template * Update README.md Updated a few words about access control and sign in. * added gifs for sharing apps (#5433) * [ImgBot] Optimize images (#5467) *Total -- 1,409.96kb -> 1,370.42kb (2.8%) /static/animations/invite.gif -- 778.42kb -> 751.72kb (3.43%) /static/animations/login-google.gif -- 625.10kb -> 612.35kb (2.04%) /app/client/src/assets/icons/comments/chat.svg -- 0.44kb -> 0.43kb (1.79%) /app/client/src/assets/icons/comments/comment-mode-unread-indicator.svg -- 0.58kb -> 0.57kb (1.69%) /app/client/src/assets/icons/comments/notifications-empty-state.svg -- 4.78kb -> 4.71kb (1.39%) /app/client/src/assets/icons/widget/embed.svg -- 0.64kb -> 0.64kb (0.46%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]> * Update form label changes (#5468) * Revert "Enable total number of rows and page size for server side pagination in table widget (#4863)" (#5469) This reverts commit related to #2230 & #1578. We will revisit this problem again and implement the solution based on the discussion in the thread. * Bump prismjs from 1.23.0 to 1.24.0 in /app/client (#5458) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated Template * Added delay after typing in Cypress test (#4168) * added delay after typing * updated method * updated type in test * updated common method * Added wait between CreationOfUniqueAPIcheck() Added delay between CreationOfUniqueAPIcheck() to prevent the stale exception. * Updated API name * Upated spec to handle retry Co-authored-by: arslanhaiderbuttar <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> * Updated Template * fix: comma-separated splitting of image url in table col of type image (#4427) * fix for comma separated splitting of image url in table col of type image * feat: add object fit control (#4986) * Added attribute to image widget to change cover properties * Fix invalid quotes breaking evaluation (#5413) * Feature/editor simplify - API to work with mock data sets (#5421) * Added an API to get list of mock datsets Removed the flow of * Removed the auto populate of mock datasets flow when the user sign up first time * Fixed indentation issues * Instead of sending empty datasource, change template value to empty * Add only the configs to response instead of entire mongo doc * Add API to create mock data set Co-authored-by: Tolulope Adetula <[email protected]> Co-authored-by: Paul Li <[email protected]> Co-authored-by: Satish Gandham <[email protected]> Co-authored-by: Yash <[email protected]> Co-authored-by: somangshu <[email protected]> Co-authored-by: Shrikant Sharat Kandula <[email protected]> Co-authored-by: Anagh Hegde <[email protected]> Co-authored-by: Satish Gandham <[email protected]> Co-authored-by: Rishabh Saxena <[email protected]> Co-authored-by: NandanAnantharamu <[email protected]> Co-authored-by: hetunandu <[email protected]> Co-authored-by: Sumit Kumar <[email protected]> Co-authored-by: arunvjn <[email protected]> Co-authored-by: Hetu Nandu <[email protected]> Co-authored-by: Nikhil Nandagopal <[email protected]> Co-authored-by: arslanhaiderbuttar <[email protected]> Co-authored-by: Abhijeet <[email protected]> Co-authored-by: Pranav Kanade <[email protected]> Co-authored-by: Trisha Anand <[email protected]> Co-authored-by: arslanhaiderbuttar <[email protected]> Co-authored-by: Yash <[email protected]> Co-authored-by: rahulramesha <[email protected]> Co-authored-by: Ashok Kumar M <[email protected]> Co-authored-by: Nayan <[email protected]> Co-authored-by: rahulramesha <[email protected]> Co-authored-by: akash-codemonk <[email protected]> Co-authored-by: Nidhi <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: abhishek nayak <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: Abhinav Jha <[email protected]> Co-authored-by: vihar <[email protected]> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vicky Bansal <[email protected]> Co-authored-by: akshayrangasaid <[email protected]> Co-authored-by: Confidence Okoghenun <[email protected]> Co-authored-by: YogeshJayaseelan <[email protected]> Co-authored-by: Ajinkya Kulkarni <[email protected]> Co-authored-by: Bhavin K <[email protected]>
ayushpahwa
added a commit
that referenced
this pull request
Jul 1, 2021
… call (#5529) * fix: reduced portal zindex * fix: move dropdown options to portal * fix: overlay covering widget explorer * Fix: modal and Dropdown * fix: remove unnecessary className * fix: remove console statement * FEATURE-2111 : Show/Hide Table Controls -- Add the header options section for the visibility setting -- Render conditionally the header part based on the setting * FEATURE-2111 : Show/Hide Table Controls -- Remove JS convertible -- Set isBindProperty and isTriggerProperty to false * FEATURE-2111 : Show/Hide Table Controls -- PositionedContainer : Add padding-bottom: 42px in case of Table widget * FEATURE-2111 : Show/Hide Table Controls -- Remove extra space when the header options is all hidden * Revert "FEATURE-2111 : Show/Hide Table Controls" This reverts commit 1d3c2da. * FEATURE-2111 : Show/Hide table controls -- Apply some cleanup * FEATURE-2111 : Show/Hide Table Controls -- Adjust pageSize -- Change column header height -- Restore the logic for renderEmptyRow * fix: PR comments * fix: failing modal test * fix: add Layers to the dropdown * fix: Add zIndex Layers of Dropdown and Modal * - Change useEffect hook to use deep cehck for modifiers instead of refernece equality - Moemoize getThemeDetails * FIX #4731: update condition for selectedRowIndices when table widget drag and drop * FEATURE-2111 : Show/Hide Table Controls -- Use isHeaderVisible variable for conditional rendering * FIX #4875 : update modal onclick reference for same modal while pasting modal and added test case * Add API for setting page order in an application * fix: options display in deploy view * - Close the property pane at the start of the test as it's not closed in the earlier test case. * FEATURE-1726 : iframe widget -- Scaffold the widget -- Bind properties * Add API for setting page order in an application * FEATURE-2111 : Show/Hide Table Controls -- Add a migration for the header options visibilities * FEATURE-1726 : Iframe Widget -- Bind onURLChanged event listener * Add page re-order API * Add page re-order API * FEATURE-1726 : Iframe Widget -- Bind onMessageReceived -- Refactor event bindings * Moved constructor to the top. * FEATURE-1726 : Iframe widget -- Remove spread operator on IframeComponent -- Use a theme color by default for border color -- Fix the crash issue when the widget is removed * FEATURE-1726 : Iframe Widget -- Remove the spread operator in IframeWidget -- Connect the widget help with the correct documentation path -- Expose source and title for autocomplete -- Remove the redundant wrapping with meta from the widget * 1. Added logic to handle pageDown scenario 2. Added comments * Add test for page reorder and add order to the response * Check if user exists before loading the form (#5108) * Updated fork/duplicate test (#4923) * Updated test to handle version * updated test * added a small wait * Assertion updated * formatted code * fork test updated * dsl file added * Updated test * Try waiting in the addDsl step * Other fixes Co-authored-by: hetunandu <[email protected]> * Use assertThat type of assertions and move the order initialization logic to migration * updated test flow (#5118) * Fix: Use connection pool for Redis (#5093) * Replace single connection instance with a connection pool. This will ensure that simultaneous actions don't fail / break the connection. * Fix/api editor enhancement (#5095) * Keep datasource tab open when there are datasources configured in API editor * Save headers when users save an action as datasource * Fix incorrect action type reference (#5121) * Update config.json * Button UI Test Cases. Automated following UI test cases for button regarding the property pane: Button Style Validation Button Copy and paste Button Delete Create api, and then call it upon clicking the button widget. Create query, and then call it upon clicking the button widget. All above using JS * JS Scenario * Allow only organization admins to export application (#5085) * Added permission export:applications for admin role * Only admins are allowed to export applications Co-authored-by: Pranav Kanade <[email protected]> * Add an option to set tags on transactions #5147 * 1. Add migration logic 2. Add order while creating pages * - Set the default perfTags value to [] * - Fix typo in type definitions * 1. Fix failing unit tests for the page reorder * Modifying PR template to revert to older version (#5154) * [Feature] Smart Substitution for JSON fields in Mongo Form (#5136) * Reduced verbosity of the command names for Insert, Find and Delete * WIP : Smart substitution untested changes for mongo form * Tested code for smart substitution working for mongo form fields * Added test case for assert for smart substitution * Fix merge conficts * Cypress.json update * Deleted Hard Waits. Deleted Hard Waits. * Change the test scenario * fix for #5073 * Added Documentation for Windows WSL2 Client Setup * Fix: updating basic dsl for fork and duplicate feature cypress specs (#5152) * dip * dip * Resolved Conflict in QueryEditor.json file Resolved Conflict in QueryEditor.json file * Changing instruction for better setup * Ignore the order of the page while checking the published and edited pages test * Feature/signup success url (#5124) * Reset the user in store on 401s (#5153) * Fature/add pagination in notifications (#5096) * -added pagination to notifications API * -add unit tests for notification pagination * -added unread count in get notifications API * -moved notification creations to notification service from comment service * -add repository method to mark a notification as read * -added repository to update isRead by for username * -add API to mark notification as read * -addd application id and application name in notification * -save application id and name in notification when creating notification for comment and comment threads * -added page id, from user information in notifications * -fixed failing unit test due to dependency error * -removed unused imports * -extended base controller in notification controller * - introduced pagination based on before created data instead of offset based pagination * -moved application id, name and page id inside comment from notification * -moved author information from notification to comment thread * -return data from notification service instead of the response object in the mark read or unread API * - Remove the is_array check * Profile image updates (#4783) * Fix: parse json/jsonb data type values as json for postgres plugin (#5135) * parse json/jsonb data type values as json * add support for json (non binary, earlier support for jsonb was added) * Highlight the second item in in the omnibar search results (#4611) * Comments feature fixes (view mode) (#5081) * Snowflake integration (#5176) * POC for snowflake integration with Appsmith This is just a rough version to see if the functionality works. Needs to be cleaned up & enhanced for production usage. * Plugin with connection, monos, ds testing, validation, templates, structure and forms * Better comments * Default schema to public * Changed logging destination, populated request in result and used thread group for datasource creation Co-authored-by: Arpit Mohan <[email protected]> * Add widget ID, widget type to property pane open perforamnce tracker. * removed unwanted wait (#5206) * Feature: Widget Grouping Phase II (#4825) * dip * dip * Cleaning up grid density positioning. * dip * dip * dip * dip * code clean up * dip * dip(restructuring widget selection) * Deselect parents and children of a widget when user multi selects. * dip * dip * dip * dip * dip * fixing a bad merge * fixing tests * adding jest tests. * common util * dip * dip * fixes * restrict in deploy mode. * fixing dynamic layout. * fixing tests. * on paste fix. * fixing specs. * addressing code review comments * dip * dip * dip * fixing specs. * fix: app/server/appsmith-interfaces/pom.xml & app/server/appsmith-server/pom.xml to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052449 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052450 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1054588 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056414 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056416 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056417 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056418 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056419 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056420 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056421 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056424 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056425 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056426 - https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056427 - https://snyk.io/vuln/SNYK-JAVA-COMMONSBEANUTILS-460111 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1020439 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1070799 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1082238 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1083991 - https://snyk.io/vuln/SNYK-JAVA-IONETTY-1089809 - https://snyk.io/vuln/SNYK-JAVA-IOPROJECTREACTORNETTY-559154 - https://snyk.io/vuln/SNYK-JAVA-IOPROJECTREACTORNETTY-559155 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1009832 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1296829 - https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORKSECURITY-1290497 - https://snyk.io/vuln/SNYK-JAVA-ORGYAML-537645 * Fix: Show error callout in api pane when there is an error (#4827) * Fixed and updated Button Specs. Fixed "Button-Call-Query Validation" test case in Button Spec and updated Copy, delete widget test cases. * Add commands in Command.js Add commands in Command.js copyWidget, deleteWidget * Fix app publish event sent at wrong times * Fix redirect URL on 401s (#5230) * Support for orphan API without any datasource added for import-export functionality (#5232) * Remove * import statements * Update README.md * Typo * Another typo 🤦🏻♂️ * [Snyk] Security upgrade net.minidev:json-smart from 2.3 to 2.4.7 (#5225) * fix: app/server/appsmith-interfaces/pom.xml to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JAVA-NETMINIDEV-1078499 - https://snyk.io/vuln/SNYK-JAVA-NETMINIDEV-1298655 * Updating the json-smart dependency to the latest one Co-authored-by: Arpit Mohan <[email protected]> * Merge the two update commands into a single update command in Mongo Form (#5171) * Update commands have been merged into a single update command for both single and multi updates * Added migrations to migrate any update one mongo form command to new update command * Incorporated review comments * Schema info in templates query (#5244) * Commenting out migration for quick fix to bring up release (#5248) * List Widget Phase 2 (#4189) * update meta properties + default properties map * update widget registery * update get meta property * update metahoc + widgetfactory + data tree evaluator * try sending function as string to worker * revert data tree evaluator update * pass default props map from dataTreeWidget file * wip * save child meta properties * remove console.log * save meta and default map in list * update listwidget * remove console.log + unused variables * revert getMetaPropertiesMap function * fix data tree test * fix list widget test * fix entity definition test * fix overriting of item in updatedItems * remove todo comments * fix meta prop issue * revert making meta properties from undefiend to "" & fix filepicker bug * fix test case * change items to listData and updatedItems to items * remove console.log * fix test * extract derived properties to dervied.js * disabled top, left, right resize handler list widget container * add test for dervied js * add test for selectedItem * fix background color bug on hover * remove console.log * fix chart widget inside list widget * fix checkbox issue + points raised by yogesh * revert the createImmerReducer usage * fix parse derived properties * remove internal props object that fails the test * fix import typo * allow bottom resize handler * fix template height check * fix template height check * update template size check * fix the is visible invalid prop issue * fix migration of list widget phase 2 * fix migration * remove unused import * fix migration * fix migration * remove console.log * hide delete option for container in entity explorer * fix testcases * remove unused import * fix switch widget meta prop Co-authored-by: root <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> * Fix publish application event not being sent * Change the logic to have check for the order of all the pages * Fix Table Widget Filter issue (#3975) * Fix issue where non-string empty values are not correctly filtered * Add unit test for fix * Updated Widgets_form_input_table_default_validation.js Updated Widgets_form_input_table_default_validation.js * update gifs on readme * Change the test method name to more meaningful,.equals for boolean comparision, fix indentation * Migration for createdAt and updatedAt field for userCollection if not present (#5249) * [ImgBot] Optimize images (#5260) *Total -- 1,360.99kb -> 1,333.59kb (2.01%) /static/animations/running-api.gif -- 1,353.80kb -> 1,326.48kb (2.02%) /app/client/src/assets/images/InspectElement.svg -- 4.50kb -> 4.43kb (1.46%) /app/client/src/assets/icons/comments/down-arrow.svg -- 0.32kb -> 0.32kb (1.21%) /app/client/src/assets/icons/ads/bell.svg -- 0.38kb -> 0.37kb (0.78%) /app/client/src/assets/icons/ads/upload_success.svg -- 0.48kb -> 0.48kb (0.61%) /app/client/src/assets/icons/ads/download.svg -- 0.60kb -> 0.60kb (0.49%) /app/client/src/assets/icons/comments/eye.svg -- 0.91kb -> 0.91kb (0.32%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]> * Run tests for all approved PRs (#5275) * Fix: Log dependent property values in debugger when a property is updated (#4865) * [ImgBot] Optimize images (#5277) *Total -- 3,594.44kb -> 3,429.78kb (4.58%) /static/animations/widgets.gif -- 1,349.47kb -> 1,261.08kb (6.55%) /static/animations/javascript.gif -- 2,244.10kb -> 2,167.84kb (3.4%) /app/client/src/assets/icons/comments/filter.svg -- 0.86kb -> 0.86kb (0.34%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]> * FEATURE-1726 : Iframe Widget -- Set default source url to wikipedia.org -- Fix typo on the tooltip of onURLChanged, url to URL -- Fix the issue which is related to reduced iframe in its deploy mode -- Fix the issue which is related to the inclusion of nearby widgets in deploy mode -- Add Expected Data Type fields with regard to borderOpacity and borderWidth * Generate linting errors via JSHint (#5034) * Mongo For Update Migrations (#5291) * Commenting out migration for quick fix to bring up release * Added null checks for the incomplete configured update single and update many queries * Bug Fix: Fix dynamic binding substitution failure with Firestore `where` condition input boxes. (#5280) Modify dynamic binding substitution method to handle list and map types containing generic type values. * Removed intermediate navigation to datasource list page. (#5304) * Fix to enable scroll in sql query results. (#5091) * Dynamically adjust table virtualizer's height according to resizer * Remove unused configurations in Netlify * Use loadash get function to add fall back value to datasource url (#5285) * Bump ws from 6.2.1 to 6.2.2 in /app/client (#4941) Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](https://github.com/websockets/ws/commits) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added Cypress tests for tab widget (#4345) * Added tests for tab widget * Added another test * Commone method updated * commented test * Set the order to published pages * Remove the unnecessary comments * Fix cyclical dependency issue when Api returns an error (#5333) Co-authored-by: Trisha Anand <[email protected]> * Error message when updating duplicate application name modified to give more contextual information (#5341) * Feature/implement comment thread subscriber (#5261) * -send email to users who are subscribed to a thread only * -fixed null pointer exception while set subscriber in create thread * -updated as per PR comments and review * Enable total number of rows and page size for server side pagination in table widget (#4863) * Add defaultPageSize and totalRecordsCount properties in table widget * Changing next button disable * Added checks for properties change * Handle defaultPageSize change * Updated util.test to handle new table properties * Configure for cypress test for page size and total records count properties * Added cypress test for default page size and total records count validation * Fix test cases * Handle empty space for page size is less than availabe space in table widget * Minor fixes for errors (#5361) * Fixed empty area issue when columns are hidden in published mode (#5162) * Create appsmith_templates.md (#4412) * Create appsmith_templates.md * Update appsmith_templates.md * Update office_hours.md * Update README.md * Update README.md * Update appsmith_templates.md * Notification updates (#5239) * Show the associated page name subtly in the omnibar (#5120) * bug/duplicate application name error will be handled (#5316) * will show last saved app name if save app name action results in error * handled duplicate appname update for editing cards * fixed the app icon update bug * updated list widget dsl * Update comments onboarding carousel images (#5373) * Set mode for comments (#5372) * Fix bug where some fields are missing for notifications from the API (#5336) * -set createdAt and type fields in notification -add threadId in response for comment * -fixed bug with unread notification count * Minor collab fixes (#5271) * Fix: Fixes a bug in onboarding flow step 1 (#5363) * API for generating a page with UI based on the structure of a given database table (#5269) * Keymapping, Clone actions from template application, Used exported application JSON file as template app * Delete references of widgets from action config if extra widgets not required * Separate API added when pageId is not present with the client * Added TCs * Update in regex, enable reqArgsConstructor, separate DTO for CRUD page * Make the whole window scrollable instead of the main container (#5369) * Adding detailed steps on adding a new plugin (#5388) * Update links on README (#5378) * Correcting typo in plugin contribution guide * Chart UI test cases (#5370) * Chart UI Test Cases Added UI Test cases for Chart Widget. - All Chart Types - JS Scenarios - onClick Scenarios - Copy - Delete * Fixed Chart displaying issue. Fixed Chart displaying issue. * Feature: add api key based and bearer token based authentication options to REST API datasource (#5367) * add api key based and bearer token based authentication options to REST API datasource * this change is ported to release from Feature: datasource changes for api key auth, bearer token auth, combine config. #4683 * removed quotes from sql templates because of prepared statements being on (#5404) removed comments from sql templates confusing users with errors because of linting * chore: Adds Community Call for Jun 24 * Security upgrade node-sass from 4.14.1 to 6.0.1 The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TRIMNEWLINES-1298042 * Changes to show multiple messages for a log in the debugger (#5144) * [Feature] Widget Grouping Phase - 3 (Cut Copy Paste) (#5083) * Cut copy paste first cut * removed different parent groups logic * mouseup on the outer canvas removes selections. * bug fix * remove unwanted dead code. * Adding tests * build fix * min height fixes * fixing specs. * fixing specs. * Onboarding typeform related fixes (#5416) * Added pod label automation for the new iFrame widget (#5440) * Test updated as it was flaky (#5441) * Fix the comment missing issue when new users added to organization (#5314) * -Add the newly added user to existing comment threads * -update PR as per review comment * -updated the PR as per review * Manual test Ideas for GoogleSheets and Mongo DB Form Input (#4857) * FIX #4627: updated css to change button widget height when deployed (#5439) This fixes the difference in the height of a button widget between edit mode and deploy mode. * Removed Reload action (#5450) * removed Reload action * count assertion removed * Update/bump node version in the doc (#5455) * [Mongo Plugin] Raw is now a command option instead of Form vs Raw (#5446) * Raw is now a command option instead of Form vs Raw * Added database migration for migration raw input type to be of raw command type * Fixed test case failure * Minor cleanup * Updated Template * Updated Template * Updated Template * Update README.md Updated a few words about access control and sign in. * added gifs for sharing apps (#5433) * [ImgBot] Optimize images (#5467) *Total -- 1,409.96kb -> 1,370.42kb (2.8%) /static/animations/invite.gif -- 778.42kb -> 751.72kb (3.43%) /static/animations/login-google.gif -- 625.10kb -> 612.35kb (2.04%) /app/client/src/assets/icons/comments/chat.svg -- 0.44kb -> 0.43kb (1.79%) /app/client/src/assets/icons/comments/comment-mode-unread-indicator.svg -- 0.58kb -> 0.57kb (1.69%) /app/client/src/assets/icons/comments/notifications-empty-state.svg -- 4.78kb -> 4.71kb (1.39%) /app/client/src/assets/icons/widget/embed.svg -- 0.64kb -> 0.64kb (0.46%) Signed-off-by: ImgBotApp <[email protected]> Co-authored-by: ImgBotApp <[email protected]> * Update form label changes (#5468) * Revert "Enable total number of rows and page size for server side pagination in table widget (#4863)" (#5469) This reverts commit related to #2230 & #1578. We will revisit this problem again and implement the solution based on the discussion in the thread. * Bump prismjs from 1.23.0 to 1.24.0 in /app/client (#5458) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated Template * Added delay after typing in Cypress test (#4168) * added delay after typing * updated method * updated type in test * updated common method * Added wait between CreationOfUniqueAPIcheck() Added delay between CreationOfUniqueAPIcheck() to prevent the stale exception. * Updated API name * Upated spec to handle retry Co-authored-by: arslanhaiderbuttar <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> * Updated Template * fix: comma-separated splitting of image url in table col of type image (#4427) * fix for comma separated splitting of image url in table col of type image * feat: add object fit control (#4986) * Added attribute to image widget to change cover properties * Fix invalid quotes breaking evaluation (#5413) * Feature/editor simplify - API to work with mock data sets (#5421) * Added an API to get list of mock datsets Removed the flow of * Removed the auto populate of mock datasets flow when the user sign up first time * Fixed indentation issues * Instead of sending empty datasource, change template value to empty * Add only the configs to response instead of entire mongo doc * Add API to create mock data set * Added default params to the navigateTo field Co-authored-by: Tolulope Adetula <[email protected]> Co-authored-by: Paul Li <[email protected]> Co-authored-by: Satish Gandham <[email protected]> Co-authored-by: Yash <[email protected]> Co-authored-by: somangshu <[email protected]> Co-authored-by: Shrikant Sharat Kandula <[email protected]> Co-authored-by: Anagh Hegde <[email protected]> Co-authored-by: Satish Gandham <[email protected]> Co-authored-by: Rishabh Saxena <[email protected]> Co-authored-by: NandanAnantharamu <[email protected]> Co-authored-by: hetunandu <[email protected]> Co-authored-by: Sumit Kumar <[email protected]> Co-authored-by: arunvjn <[email protected]> Co-authored-by: Hetu Nandu <[email protected]> Co-authored-by: Nikhil Nandagopal <[email protected]> Co-authored-by: arslanhaiderbuttar <[email protected]> Co-authored-by: Abhijeet <[email protected]> Co-authored-by: Pranav Kanade <[email protected]> Co-authored-by: Trisha Anand <[email protected]> Co-authored-by: arslanhaiderbuttar <[email protected]> Co-authored-by: Yash <[email protected]> Co-authored-by: rahulramesha <[email protected]> Co-authored-by: Ashok Kumar M <[email protected]> Co-authored-by: Nayan <[email protected]> Co-authored-by: rahulramesha <[email protected]> Co-authored-by: akash-codemonk <[email protected]> Co-authored-by: Nidhi <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: abhishek nayak <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Pawan Kumar <[email protected]> Co-authored-by: Abhinav Jha <[email protected]> Co-authored-by: vihar <[email protected]> Co-authored-by: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com> Co-authored-by: ImgBotApp <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vicky Bansal <[email protected]> Co-authored-by: akshayrangasaid <[email protected]> Co-authored-by: Confidence Okoghenun <[email protected]> Co-authored-by: YogeshJayaseelan <[email protected]> Co-authored-by: Ajinkya Kulkarni <[email protected]> Co-authored-by: Bhavin K <[email protected]>
| @@ -124,18 +124,32 @@ const withMeta = (WrappedWidget: typeof BaseWidget) => { | |||
| handleUpdateWidgetMetaProperty() { | |||
| const { executeAction, updateWidgetMetaProperty } = this.context; | |||
| const { widgetId, widgetName } = this.props; | |||
| const metaOptions = this.props.__metaOptions; | |||
There was a problem hiding this comment.
Can you help me understand where we use meta options in List Widget? @jsartisan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes input widgets work in list widget
Fixes #2389
Test coverage results 🧪
🟢 Total coverage has increased