PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants, CHANGES.txt entries (#13845) #13891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructor variants, CHANGES.txt entries (apache#13845) (cherry picked from commit dab7311) Resolved Conflicts: lucene/CHANGES.txt
javanna
reviewed
Oct 14, 2024
| @@ -47,6 +52,9 @@ API Changes | |||
| the entire segment should be scored. Subclasses that override the method should instead override its replacement. | |||
| (Luca Cavanna) | |||
|
|
|||
| * GITHUB#13757: For similarities, provide default computeNorm implementation and remove remaining discountOverlaps setters. | |||
| (Christine Poerschke, Adrien Grand, Robert Muir) | |||
There was a problem hiding this comment.
I am afraid is is now too late to modify the changelog for 9.12, as it's already been released?
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit dab7311)
Resolved Conflicts:
lucene/CHANGES.txt