Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 13757 follow-up: add missing with-discountOverlaps Similarity constructor variants, CHANGES.txt entries (#13845) #13858

Merged

Conversation

cpoerschke
Copy link
Contributor

(cherry picked from commit dab7311)
(cherry picked from commit cbd8b52)

Resolved Conflicts:
lucene/CHANGES.txt

…tructor variants, CHANGES.txt entries (apache#13845)

(cherry picked from commit dab7311)
(cherry picked from commit cbd8b52)

Resolved Conflicts:
	lucene/CHANGES.txt
Comment on lines +130 to +131
* GITHUB#13845: Add missing with-discountOverlaps Similarity constructor variants. (Pierre Salagnac, Christine Poerschke, Robert Muir)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this is for the 10.0 section and that after this PR is merged (if it is merged) then I'd 10.1 to 10.0 section move the entry correspondingly on the main and branch_10x branches.

@cpoerschke
Copy link
Contributor Author

@cpoerschke cpoerschke marked this pull request as ready for review October 4, 2024 16:44
@cpoerschke cpoerschke added this to the 10.0.0 milestone Oct 4, 2024
@javanna javanna merged commit 0a57309 into apache:branch_10_0 Oct 9, 2024
2 checks passed
@javanna
Copy link
Contributor

javanna commented Oct 9, 2024

I merged this to branch_10_0. Does this also need to backported to 9_12 for the next 9.12.1 patch release?

@javanna
Copy link
Contributor

javanna commented Oct 9, 2024

Heads up: I moved the CHANGES entry in main and branch_10x to the 10.0.0 section. See 111fc6f .

@cpoerschke
Copy link
Contributor Author

Heads up: I moved the CHANGES entry in main and branch_10x to the 10.0.0 section. ...

Thanks!

... Does this also need to backported to 9_12 for the next 9.12.1 patch release?

That would be good, yes, #13891 opened for it.

@cpoerschke cpoerschke deleted the branch_10_0-backport-pr-13845 branch October 11, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants