Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor](opt) remove redundant use_default_implementation_for_nulls() of some BE codes #46796

Merged
merged 1 commit into from
Jan 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions be/src/vec/functions/array/function_array_difference.h
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ class FunctionArrayDifference : public IFunction {

size_t get_number_of_arguments() const override { return 1; }

bool use_default_implementation_for_nulls() const override { return true; }

DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
DCHECK(is_array(arguments[0]))
<< "argument for function: " << name << " should be DataTypeArray but it has type "
Expand Down
2 changes: 0 additions & 2 deletions be/src/vec/functions/function_hll.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ class FunctionHllFromBase64 : public IFunction {

size_t get_number_of_arguments() const override { return 1; }

bool use_default_implementation_for_nulls() const override { return true; }

Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
uint32_t result, size_t input_rows_count) const override {
auto res_null_map = ColumnUInt8::create(input_rows_count, 0);
Expand Down
2 changes: 0 additions & 2 deletions be/src/vec/functions/function_multi_same_args.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ class FunctionMultiSameArgs : public IFunction {

String get_name() const override { return name; }

bool use_default_implementation_for_nulls() const override { return true; }

bool is_variadic() const override { return true; }

size_t get_number_of_arguments() const override { return 0; }
Expand Down
2 changes: 0 additions & 2 deletions be/src/vec/functions/function_struct_element.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ class FunctionStructElement : public IFunction {
// Get function name.
String get_name() const override { return name; }

bool use_default_implementation_for_nulls() const override { return true; }

size_t get_number_of_arguments() const override { return 2; }

ColumnNumbers get_arguments_that_are_always_constant() const override { return {1}; }
Expand Down
2 changes: 0 additions & 2 deletions be/src/vec/functions/function_time_value_to_field.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ class FunctionTimeValueToField : public IFunction {
return std::make_shared<ToDataType>();
}

bool use_default_implementation_for_nulls() const override { return true; }

Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
uint32_t result, size_t input_rows_count) const override {
DCHECK_EQ(arguments.size(), 1);
Expand Down
2 changes: 0 additions & 2 deletions be/src/vec/functions/function_totype.h
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,6 @@ class FunctionStringOperateToNullType : public IFunction {
return make_nullable(std::make_shared<typename Impl::ReturnType>());
}

bool use_default_implementation_for_nulls() const override { return true; }

Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
uint32_t result, size_t input_rows_count) const override {
auto null_map = ColumnUInt8::create(input_rows_count, 0);
Expand Down
Loading