-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](opt) remove redundant use_default_implementation_for_nulls() of some BE codes #46796
[refactor](opt) remove redundant use_default_implementation_for_nulls() of some BE codes #46796
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 32611 ms
|
TPC-DS: Total hot run time: 193017 ms
|
ClickBench: Total hot run time: 31.75 s
|
faa72fd
to
2ca36d4
Compare
run buildall |
TPC-H: Total hot run time: 32767 ms
|
TPC-DS: Total hot run time: 194727 ms
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.25 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Problem Summary:
The function
use_default_implementation_for_nulls()
has beentrue
in their parent classIFunction{}
, so we can safely remove this part in some BE codes if its value was set totrue
.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)