[CELEBORN-1811] Update default value for celeborn.master.slot.assign.extraSlots
#3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update |
pan3793
reviewed
Dec 30, 2024
|
@pan3793 @SteNicholas This PR is ready. How about now? |
pan3793
changed the title
celeborn.master.slot.assignextraSlotsceleborn.master.slot.assign.extraSlots
@FMX same request |
|
The migration guide has been updated. |
pan3793
approved these changes
Dec 31, 2024
SteNicholas
approved these changes
Dec 31, 2024
|
LGTM. Merged to main(v0.6.0). |
SteNicholas
added a commit
that referenced
this pull request
Jan 2, 2025
…o explain default behavior in description ### What changes were proposed in this pull request? Change `celeborn.<module>.io.mode` optional to explain default behavior in description. ### Why are the changes needed? The default value of `celeborn.<module>.io.mode` in document could be changed by whether epoll mode is available for different os. Therefore, `celeborn.<module>.io.mode` should be changed to optional and explained the default behavior in description of option. Follow up #3039 (comment). ### Does this PR introduce _any_ user-facing change? `celeborn.<module>.io.mode` is optional and explains default behavior in description. ### How was this patch tested? CI. Closes #3044 from SteNicholas/CELEBORN-1774. Authored-by: SteNicholas <[email protected]> Signed-off-by: SteNicholas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To avoid possible worker load skew for the stages with tiny reducer numbers.
Why are the changes needed?
If a stage has tiny reducers and skewed partitions, The default value will lead to serious worker load imbalance cause some workers unable to handle shuffle data.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
GA and cluster test.