[CELEBORN-1774][FOLLOWUP] Change celeborn.<module>.io.mode optional to explain default behavior in description #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o explain default behavior in description
turboFei
approved these changes
Jan 1, 2025
pan3793
approved these changes
Jan 2, 2025
|
Merged to main(v0.6.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
celeborn.<module>.io.modeoptional to explain default behavior in description.Why are the changes needed?
The default value of
celeborn.<module>.io.modein document could be changed by whether epoll mode is available for different os. Therefore,celeborn.<module>.io.modeshould be changed to optional and explained the default behavior in description of option.Follow up #3039 (comment).
Does this PR introduce any user-facing change?
celeborn.<module>.io.modeis optional and explains default behavior in description.How was this patch tested?
CI.