CASSGO-15 Remove global NewBatch function #1762
Merged
+2
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testisnullus
approved these changes
Jun 7, 2024
joao-r-reis
changed the title
joao-r-reis
approved these changes
Oct 31, 2024
|
Please format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the We need another committer +1 to merge this. |
tengu-alt
force-pushed
the
remove-global-newbatch
branch
3 times, most recently
from
6718f54
to
9e096aa
Compare
tengu-alt
changed the title
Jacko161
approved these changes
Nov 18, 2024
|
Please update the commit message to include Jackson as a reviewer and then I'll merge this 👍 |
Batch should behave like Query, and need to be created from a session. patch by Oleksandr Luzhniy; reviewed by João Reis, Danylo Savchenko, Jackson Fleming, for CASSGO-15
tengu-alt
force-pushed
the
remove-global-newbatch
branch
from
9e096aa
to
a6cab85
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Issues #1433 and #1065, this PR removes the global
NewBatch()function due to its deprecation.