CASSGO-7 Change Batch API to be consistent with Query() #1764
Conversation
tengu-alt
force-pushed
the
batch-exec
branch
3 times, most recently
from
5a44475
to
a6d1a09
Compare
|
@tengu-alt we should also add a new
|
joao-r-reis
changed the title
@joao-r-reis I do not clearly understand. The |
|
The original issue mentions the rename |
|
global |
I see, thank you. Done, also I've changed the |
| func (b *Batch) Exec() error { | ||
| iter := b.session.executeBatch(b) | ||
| return iter.Close() | ||
| } |
There was a problem hiding this comment.
I think you should add a doc here because it is meant to be used by users. Maybe use the same description as for Session.ExecuteBatch().
Also, add a doc for Session.Batch() too.
session.go
Outdated
| spec: &NonSpeculativeExecution{}, | ||
| routingInfo: &queryRoutingInfo{}, | ||
| } | ||
|
|
There was a problem hiding this comment.
duplicate code (NewBatch)
There was a problem hiding this comment.
I kept the session.NewBatch and marked it as deprecated according to your suggestion.
There was a problem hiding this comment.
Yes thanks but please create a private function that both can call or make one of them call the other so we don't have the duplicate code.
|
Please format your commit message following the rules stated in CONTRIBUTING.md and add this JIRA to the We need another committer +1 to merge this. |
Exec() method for batch was added & Query() method was refactored. Batch for now behaves the same way as query. patch by Oleksandr Luzhniy; reviewed by João Reis, Danylo Savchenko, Bohdan Siryk for CASSGO-7
tengu-alt
force-pushed
the
batch-exec
branch
from
bcfb3cc
to
2c5b2be
Compare
tengu-alt
changed the title
According to issue #1187, I have refactored the Query() method for the batch and implemented the Exec() method for the batch structure to save the general pattern of the query execution, and saved the older method (session.ExecuteBatch()) for backward compatibility.
This means the batch for now behaves the same way as query.