fix(prometheus): disable features when plugin is turned off #11047
Conversation
… disabling, remove obsolete tests
… the wrong judgment
apisix/cli/ngx_tpl.lua
Outdated
|
|
||
| {% else %} | ||
|
|
||
| init_by_lua_block { |
There was a problem hiding this comment.
- this block is for
streamonly, please take care of thehttp - init_by_lua_block should be kept
There was a problem hiding this comment.
- this block is for
streamonly, please take care of thehttp- init_by_lua_block should be kept
Hi. I have made a corresponding modification based on your two modification opinions
|
@motongxue Please fix the lint checks. |
|
Could you add test cases to cover this? |
t/xrpc/prometheus2.t
Outdated
| location /t { | ||
| content_by_lua_block { | ||
| local plugin = require("apisix.plugins.prometheus") | ||
| local ok, err = plugin.check_schema({}) |
There was a problem hiding this comment.
Why do you add this test case?
t/xrpc/prometheus2.t
Outdated
| - limit-count | ||
| --- request | ||
| GET /apisix/prometheus/metrics | ||
| --- error_code: 404 |
There was a problem hiding this comment.
I think you only need to add this test case into the existing test cases?
There was a problem hiding this comment.
Okay, I will do it according to your suggestions, although existing test case (t/xprc/prometheus.t) I can't test it in my local development environment.
|
@motongxue Can you address the failing CI? |
|
Description
The Prometheus plugin is a crucial component for observability within Apache APISIX. However, I've encountered an issue where, even after the Prometheus plugin is disabled, all features related to Prometheus are not entirely shut down. This behavior could lead to unexpected performance impacts and data leakage.
When the Prometheus plugin is disabled, all functionalities and metrics associated with Prometheus should be completely deactivated to ensure no unnecessary overhead or data exposure.
Fixes # (issue)
Checklist