Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Disable All Prometheus-related Features When Prometheus Plugin is Turned Off #11046

Closed
motongxue opened this issue Mar 15, 2024 · 1 comment · Fixed by #11117
Closed

Comments

@motongxue
Copy link
Contributor

Current Behavior

The Prometheus plugin is a crucial component for observability within Apache APISIX. However, I've encountered an issue where, even after the Prometheus plugin is disabled, all features related to Prometheus are not entirely shut down. This behavior could lead to unexpected performance impacts and data leakage.

Upon disabling the Prometheus plugin, certain Prometheus-related functionalities continue to operate, suggesting that not all components associated with the plugin are fully turned off.

Expected Behavior

When the Prometheus plugin is disabled, all functionalities and metrics associated with Prometheus should be completely deactivated to ensure no unnecessary overhead or data exposure.

Error Logs

No response

Steps to Reproduce

  1. Enable the Prometheus plugin in Apache APISIX.
  2. Generate some traffic and observe Prometheus metrics being collected.
  3. Disable the Prometheus plugin.
  4. Observe that metrics or features associated with Prometheus are still active or being collected.

Environment

  • APISIX version (run apisix version): 3.8.0
  • Operating system (run uname -a): Linux 4f398f8410bc 6.5.0-21-generic balancer: support domain. #21~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Feb 9 13:32:52 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
  • OpenResty / Nginx version (run openresty -V or nginx -V): nginx version: openresty/1.25.3.1
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):
@shreemaan-abhishek
Copy link
Contributor

To be fixed by #11047. Thanks for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants