Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support openresty-1.25.3.1 #10887

Merged
merged 33 commits into from
Feb 26, 2024
Merged

feat: support openresty-1.25.3.1 #10887

merged 33 commits into from
Feb 26, 2024

Conversation

zll600
Copy link
Contributor

@zll600 zll600 commented Jan 30, 2024

Description

Fixes #6403

Breaking Change:

  • If enable_http2 is set for any entry under apisix.ssl.listen or apisix.ssl.node_listen , all entries will enable http2. Becuase nginx-1.25.3 change the configuration of http2

from

server {
       listen 443 ssl http2;
}

to

server {
       http2 on;
       listen 443 ssl;
}

From user perspective, if I have following configuration, the port 9443 and 9444 will both support http2. The enable_http2: false takes no effect for port 9444

apisix:
  ssl:
    listen:
      - port: 9443
        enable_http2: true # enable http2
      - port: 9444
        enable_http2: false # disable http2.

doc for ngx.req.read_body from lua-nginx-module-0.10.26

Due to the stream processing feature of HTTP/2 or HTTP/3, this api could potentially block the entire request. Therefore, this api is effective only when HTTP/2 or HTTP/3 requests send content-length header. For requests with versions lower than HTTP/2, this api can still be used without any problems.

  • apisix will no longer support tongsuo. because QUIC of nginx needs QUIC TLS which tongsuo does not support currently.

related PRs:

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@zll600 zll600 changed the title Upgrade openresty 1.25.3.1 chore: upgrade openresty 1.25.3.1 Feb 8, 2024
apisix/cli/ngx_tpl.lua Show resolved Hide resolved
apisix/plugins/ext-plugin/init.lua Show resolved Hide resolved
apisix/core/request.lua Show resolved Hide resolved
@zll600 zll600 marked this pull request as ready for review February 18, 2024 00:25
apisix/cli/ops.lua Outdated Show resolved Hide resolved
@monkeyDluffy6017
Copy link
Contributor

Please fix the code lint error in ci

@zll600
Copy link
Contributor Author

zll600 commented Feb 20, 2024

@monkeyDluffy6017 Could you help me rerun the CI?

@zll600
Copy link
Contributor Author

zll600 commented Feb 20, 2024

@monkeyDluffy6017 Could you help me rerun the failed CI?
In my own repo, All CIs except GM are pass, ref: https://github.com/zll600/apisix/pull/2

apisix/core/request.lua Show resolved Hide resolved
apisix/plugins/ext-plugin/init.lua Show resolved Hide resolved
ci/common.sh Outdated Show resolved Hide resolved
ci/common.sh Outdated Show resolved Hide resolved
utils/install-dependencies.sh Outdated Show resolved Hide resolved
@monkeyDluffy6017 monkeyDluffy6017 changed the title chore: upgrade openresty 1.25.3.1 feat: support openresty-1.25.3.1 Feb 20, 2024
@monkeyDluffy6017
Copy link
Contributor

Maybe you could remove CI GM temporarily

membphis
membphis previously approved these changes Feb 23, 2024
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

t/plugin/azure-functions.t Outdated Show resolved Hide resolved
@monkeyDluffy6017 monkeyDluffy6017 merged commit 44c1180 into apache:master Feb 26, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: apisix support QUIC+HTTP3
4 participants