-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support openresty-1.25.3.1 #10887
Merged
monkeyDluffy6017
merged 33 commits into
apache:master
from
zll600:upgrade_openresty-1.25.3.1
Feb 26, 2024
Merged
feat: support openresty-1.25.3.1 #10887
monkeyDluffy6017
merged 33 commits into
apache:master
from
zll600:upgrade_openresty-1.25.3.1
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9fcb781.
membphis
reviewed
Feb 5, 2024
zll600
commented
Feb 18, 2024
membphis
reviewed
Feb 18, 2024
Please fix the code lint error in ci |
@monkeyDluffy6017 Could you help me rerun the CI? |
@monkeyDluffy6017 Could you help me rerun the failed CI? |
monkeyDluffy6017
changed the title
chore: upgrade openresty 1.25.3.1
feat: support openresty-1.25.3.1
Feb 20, 2024
zll600
requested review from
membphis,
shreemaan-abhishek and
monkeyDluffy6017
February 20, 2024 09:16
Maybe you could remove |
membphis
previously approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
monkeyDluffy6017
approved these changes
Feb 23, 2024
shreemaan-abhishek
approved these changes
Feb 23, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6403
Breaking Change:
enable_http2
is set for any entry underapisix.ssl.listen
orapisix.ssl.node_listen
, all entries willenable http2
. Becuase nginx-1.25.3 change the configuration of http2from
to
From user perspective, if I have following configuration, the port
9443
and9444
will both support http2. Theenable_http2: false
takes no effect for port9444
ngx.req.read_body
need HTTP/2 or HTTP/3 request must has acontent-length
header which is introduced in https://github.com/openresty/lua-nginx-module/tree/v0.10.26. Even for GET request, we still need sent the headercontent-length: 0
whether we callngx.req.read_body
directly or indrectly. such as https://github.com/apache/apisix/pull/10887/files#diff-d099a6d3ec103fc01c1d4354f7e3659002bd53c8bb5013b26d7ec0b88910074fR192-R193doc for ngx.req.read_body from lua-nginx-module-0.10.26
QUIC
of nginx needsQUIC TLS
which tongsuo does not support currently.related PRs:
Checklist