-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: use apisix.enable_http2 to enable HTTP/2 in APISIX #11032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add break changes in https://github.com/apache/apisix/blob/master/CHANGELOG.md, you can add a new section next release version
resolved by 96fd588. PTAL |
Description
This PR is a Breaking Change.
in #10887, I upgrade openresty-1.25.3.1 for APISIX. There is a deprecation in nginx. The
http2
parameter inlisten
directive is deprecated.In #10887, in order to maintain backward compatibility, I did not modify the method of
enable http2
in APISIX. But this will bring a breaking change to users.for example.
config.yaml
generated
nginx.conf
which127.0.0.1:9081
and127.0.0.2:9082
both can establish HTTP/2 connection. This scenario is not what user want.So I want to make a breaking change for APISIX. Only support
apisix.enable_http2
. eg.it will generate following
nginx.conf
which127.0.0.1:9081
and127.0.0.2:9082
both can establish HTTP/2 connection.The original method will no longer be supported. If you still use original way in
config.yaml
, APISIX will report an error to you.Checklist