Implement multiple label #1785
Closed
Implement multiple label #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafsun42
force-pushed
the
multiple-label-updated
branch
from
55750e4
to
0f26e04
Compare
rafsun42
requested review from
MuhammadTahaNaveed,
Zainab-Saad,
jrgemignani and
dehowef
Zainab-Saad
requested changes
Apr 29, 2024
| ListCell *lc; | ||
| char *relname; | ||
|
|
||
| Assert(list_length(label_expr->label_names) > 1); |
There was a problem hiding this comment.
CREATE (x:A:A) RETURN x results in server termination at this Assertion..
There was a problem hiding this comment.
Ah! I remember you reported this one before. I will fix it.
There was a problem hiding this comment.
Added this in my backlog.
|
@rafsun42 Looks good to me-- this seems to be a really big change seeing that it affects the regression tests in a large way. I think it should be a priority to get this reviewed by as many people as possible, so that development can continue. @jrgemignani mind taking a look? |
MuhammadTahaNaveed
added
the
override-stale
rafsun42
force-pushed
the
multiple-label-updated
branch
from
0f26e04
to
402a495
Compare
It represents label expression of different type: empty, single or multiple.
Previously, label field was char* type. The change affected the type cypher_node, cypher_relationship and cypher_target_node. As well as, any places where these types are used.
Supports queries like-
MATCH (v:A|B|C) RETURN v
MATCH ()-[e:A|B|C]->() RETURN v
Some examples of supported multiple label queries: CREATE (:a:b) MERGE (:a:b) MATCH (:a:b) MATCH (:a|b) See regress/sql/multiple_label.sql for more details on what kind of queries are supported. Change summary: --------------- * A new column `allrelations` is added to ag_label catalog * Change in creating AGE relations logic * Change in MATCH's transformation logic (related to building parse namespace item)
The logic for building vertex objects is updated. Agtype vertex objects can be built from either a single label (as a cstring) or multiple labels (as an agtype array). The following functions are updated to reflect this- agtype_typecast_vertex, agtype_in and _agtype_build_vertex. if _agtype_build_vertex is called from SQL, its label argument must be explicitly cast to avoid ambiguity in function overload. The `_label_names` function is added to extract label names from a vertex ID as a list of string. It is used as a helper function to build vertex objects. A new cache called `allrelations` is also added. This is used by _label_names to search for all labels that are related to a given relation. Multiple helper functions are added to extract label infromation from an entity ID. For example, entity's relation ID, relation name, label names. These are used by CREATE, DELETE, MERGE, VLE and SET executors for building a vertex's object or updating its relation. All test files are updated to show the label field as an array in the output. In all test SQLs, _agtype_build_vertex's label argument is explicity cast.
It updates the function filter_vertices_on_label_id(). Additional changes: ------------------- - Add internal function _label_ids
Cache issues fixed: ------------------- - Use of wrong data type for cache entry in label relation cache (pre-existing) - Use of wrong update function for catalog table (related to multiple label) Other changes: -------------- - The function _label_name() is unsupported for vertices
Changes: -------- - Update create_label_expr_relations() to return RangeVar. It removes redundant call to label_expr_relname() in the code that also calls this function. - Use deconstruct_array() to convert ArrayType* to List* - Update test files after rebase
This fixes some compile-time errors that occur if PostgreSQL is configured with the --with-llvm option.
Changes: ------- * Include missing header files * Update newly added tests * Other minor changes
Following PRs are reapplied: 1465, 1509, 1514, and 1518.
rafsun42
force-pushed
the
multiple-label-updated
branch
from
402a495
to
0fc3135
Compare
rafsun42
force-pushed
the
multiple-label-updated
branch
from
0fc3135
to
e82b9ec
Compare
|
@jrgemignani @MuhammadTahaNaveed This PR is ready for review now. It was rebased to a new remote branch |
* Regression tests * Comments * Minor overlook during rebasing
rafsun42
force-pushed
the
multiple-label-updated
branch
from
e82b9ec
to
4494c6e
Compare
|
Moved to #2082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for multiple labels in CREATE, MERGE and MATCH clause.
Important Notes:
Update:
multiple_label_16, which is based offmaster.