Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dpm automation level option #75

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

The automation level option for dpm_cluster did not match the options that are used in the UI. This is because the API uses a different word (automated vs automatic).

This change modifies the module options to match what the user sees in the vcenter UI and docs.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cluster_dpm

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.26%. Comparing base (013afa4) to head (a066ca4).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/cluster_dpm.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   26.09%   27.26%   +1.16%     
==========================================
  Files          19       22       +3     
  Lines        1667     1867     +200     
  Branches      331      357      +26     
==========================================
+ Hits          435      509      +74     
- Misses       1232     1358     +126     
Flag Coverage Δ
sanity 27.26% <33.33%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@prabinovRedhat prabinovRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the module hasn't been released yet, right? In this case, I think it's OK.

Otherwise, I should say it's a breaking change which requires a new major version. But if the module really hasn't been released yet, we can't break any existing playbooks :-)

@mikemorency
Copy link
Collaborator Author

yea, i just merged this module a few days ago so it hasnt been released yet

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemorency mikemorency merged commit 259b843 into ansible-collections:main Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants