Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary changelog entries #76

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

mariolenz
Copy link
Collaborator

@mariolenz mariolenz commented Oct 18, 2024

SUMMARY

Those changelog fragments will turn up in the changelog. I wonder if this is really helpful. I mean, it's not really a change compared to the last version, is it? Those modules haven't been part of this release. This might confuse some people.

I don't have a strong opinion on this. Just merge this PR or close it if you want to keep those (future) changelog entries. Personally, I think there hasn't been a change compared to 1.5.0 so there shouldn't be any entries in the changelog, either.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

cluster_drs_recommendations
cluster_dpm

ADDITIONAL INFORMATION

#70
#71
#73
#74
#75

cc @mikemorency

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.26%. Comparing base (013afa4) to head (4836a6b).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   26.09%   27.26%   +1.16%     
==========================================
  Files          19       22       +3     
  Lines        1667     1867     +200     
  Branches      331      357      +26     
==========================================
+ Hits          435      509      +74     
- Misses       1232     1358     +126     
Flag Coverage Δ
sanity 27.26% <ø> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariolenz mariolenz changed the title Drop unnecessary changelo entries Drop unnecessary changelog entries Oct 18, 2024
@mikemorency
Copy link
Collaborator

One of the actions requires a changelog file every PR. We should probably allow people to skip that with a label or something

@mikemorency mikemorency self-requested a review October 18, 2024 15:49
@mariolenz
Copy link
Collaborator Author

One of the actions requires a changelog file every PR. We should probably allow people to skip that with a label or something

I'm not sure if this is really helpful. I think whoever reviews a PR should decide if it's worth a changelog entry or not. On the other hand, I guess that in 80, 90 or even more % of the cases a changelog fragment is necessary. So maybe it helps if the CI checks that one exists.

This is a very special case IMHO. trivial might have been an alternative. This makes your CI happy but doesn't turn up in the changelog AFAIK.

@mariolenz mariolenz merged commit b0f83ef into ansible-collections:main Oct 20, 2024
13 checks passed
@mariolenz mariolenz deleted the 20241018-changelog branch October 20, 2024 12:11
@mariolenz
Copy link
Collaborator Author

Thanks for reviewing @mikemorency and @bardielle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants