This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Update Sunflower from M2 to M3 (#852) #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Sunflower from M2 to M3 * clean up
* feat: add accompanist dependency * feat: add accompanist dependency * feat: make systemBarsColor transparent * feat: remove systemBarPadding modifiers * feat: add more specific name for dependency and delete unsplash key * feat: delete the commented code
JolandaVerhoef
approved these changes
Aug 18, 2023
Gurupreet
reviewed
Aug 18, 2023
app/src/main/java/com/google/samples/apps/sunflower/compose/plantlist/PlantListItemView.kt
Outdated
Show resolved
Hide resolved
Gurupreet
reviewed
Aug 18, 2023
Gurupreet
reviewed
Aug 18, 2023
Gurupreet
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the readme with latest screenshots as well.
Change-Id: Iad840d29056a8a66957e55386e69733fd25d9377
This was referenced Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #852. A majority of the migration has been done by @MagicalMeghan. The remaining work left is to update colors to match the material3 color spec.