Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Add a Pull to refresh Modifier inside GalleryScreen to refresh the data #926

Conversation

SubhadeepSantra1998
Copy link

No description provided.

Copy link

google-cla bot commented Nov 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sunflower has been migrated to use Material 3 (see #883) and this reintroduces Material 2 in the codebase which is not ideal.

However, experimental support for pull to refresh in Material 3 has landed should be live in an upcoming release (see https://issuetracker.google.com/issues/261760718). So, good timing :)

Please update this pull request once a release containing pull to refresh with Material 3 is available.

@@ -119,9 +119,9 @@ retrofit2 = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofi
retrofit2-converter-gson = { module = "com.squareup.retrofit2:converter-gson", version.ref = "retrofit" }

[plugins]
android-application = { id = "com.android.application", version.ref = "androidGradlePlugin" }
android-application = { id = "com.android.application", version = "8.0.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

android-library = { id = "com.android.library", version.ref = "androidGradlePlugin" }
android-test = { id = "com.android.test", version.ref = "androidGradlePlugin" }
android-test = { id = "com.android.test", version = "8.0.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - revert

@IanGClifton IanGClifton requested review from arriolac and removed request for IanGClifton November 8, 2023 18:24
@arriolac
Copy link
Contributor

Closing this issue in favor of the Material 3 contribution in #934 from @sahilsk3333 as it is aligned with the design system of Sunflower. Thanks

@arriolac arriolac closed this Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants