Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featrue/100-HTMLParser #134

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Featrue/100-HTMLParser #134

merged 4 commits into from
Dec 13, 2023

Conversation

QW3RAT
Copy link
Contributor

@QW3RAT QW3RAT commented Dec 13, 2023

Started new branch, since in the old one i got errors in classes i didnt touched :( i think i maybe made a misstake in the rebasing there

@QW3RAT QW3RAT changed the title Moved XMLParser, Added HTMLParser and test for new class Featrue/100-HTMLParser Dec 13, 2023
@lheimbs lheimbs mentioned this pull request Dec 13, 2023
Copy link
Contributor

@lheimbs lheimbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor thing

import java.io.File

class HTMLParser {
fun loadResultsFromHtml(htmlReportPath: String?): OverallResultData {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fun loadResultsFromHtml(htmlReportPath: String?): OverallResultData {
fun loadResultsFromHtml(htmlReportPath: String): OverallResultData {

Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
@QW3RAT QW3RAT merged commit bf5b04f into main Dec 13, 2023
12 checks passed
@QW3RAT QW3RAT deleted the Feature/100-HTMLParser-2 branch December 13, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants