Feature/100 html parser #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…package "reporting" for better structuring of project. Signed-off-by: QW3RAT <[email protected]>
…package "reporting" for better structuring of project. Signed-off-by: QW3RAT <[email protected]>
…g-Framework-for-Plugins-with-Example
…gic to extract the Result class used by PITest directly instead of XML file Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
# Conflicts: # pitmutationmate/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/reporting/MyMutationResultListener.kt # pitmutationmate/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/reporting/MyMutationResultListenerFactory.kt # pitmutationmate/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/reporting/XMLParser.kt # pitmutationmate/src/main/resources/META-INF/services/org.pitest.mutationtest.MutationResultListenerFactory
Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
|
Linting fails because of error in testfile i dont want to change, to be as close to the real reports we will work with as possible |
Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
lfogarty98
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Looks good to me, I like that there is now a data structure which captures both the current-scope results as well as the related package results.
A question though: how are you handling the "mutation-specific" results such as those handled by the XML parser? For instance, line number is important since this is required for displaying the color bars after a Pitest run, so I think we do need to be able to obtain this.
|
Linter fixes are merged. Please rebase to re-lint |
Signed-off-by: Lennart Heimbs <[email protected]>
* ContextMenuAction runs pitest on all classes of the file when clicked inside file tree structure. Signed-off-by: brianneoberson <[email protected]> * Comma seperate the classes Signed-off-by: brianneoberson <[email protected]> * Disable action if not clicked inside a class Signed-off-by: brianneoberson <[email protected]> * Adapt gutter marker for kotlin classes Signed-off-by: brianneoberson <[email protected]> * Adapt context menu action to work for kotlin files Signed-off-by: brianneoberson <[email protected]> * Remove println Signed-off-by: brianneoberson <[email protected]> * Fix lint Signed-off-by: brianneoberson <[email protected]> * Override actionupdatethread Signed-off-by: brianneoberson <[email protected]> * Replace println with logger.info Signed-off-by: brianneoberson <[email protected]> --------- Signed-off-by: brianneoberson <[email protected]> Co-authored-by: Felix-012 <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
…eters Signed-off-by: Liam Fogarty <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
Signed-off-by: Liam Fogarty <[email protected]>
* Add HoverAction class to handle mouse hover events Signed-off-by: Tim Herzig <[email protected]> * show message on selected line bug: message shows when moving away from a position, not when "arriving" Signed-off-by: Tim Herzig <[email protected]> * Add hover action to show mutation results Signed-off-by: Tim Herzig <[email protected]> * remove unused imports and comments Signed-off-by: Tim Herzig <[email protected]> * lint correction Signed-off-by: Tim Herzig <[email protected]> * lint correction Signed-off-by: Tim Herzig <[email protected]> * kotlin conventions Signed-off-by: Tim Herzig <[email protected]> * lint correction Signed-off-by: Tim Herzig <[email protected]> * lint correction Signed-off-by: Tim Herzig <[email protected]> * add hover functionality while keeping click function currently commented out so that it can be demonstrated. Signed-off-by: Tim Herzig <[email protected]> * comment TODO for collective choice Signed-off-by: Tim Herzig <[email protected]> --------- Signed-off-by: Tim Herzig <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
…package "reporting" for better structuring of project. Signed-off-by: QW3RAT <[email protected]>
…gic to extract the Result class used by PITest directly instead of XML file Signed-off-by: QW3RAT <[email protected]>
Signed-off-by: QW3RAT <[email protected]>
|
I now get linting errors in parrt of the programm where i didnt changed anything :(. I'll have a look into that |
|
Just as an explanation: by merging all the previous changes made since you branched off of main you included all these files in this branches history. The linter takes all the changes that are included in this branch and subsequently it detects errors with files that have been added before we enabled the linter. If you perform a rebase now on this branch like so: and fix the merge conflicts you would get rid of all the changes already contained in In the meantime i'm closing this PR in favor of #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the parser and a rudimentary testing class for it also